Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: abci handshake is not shutdown gracefully #288

Merged

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jun 21, 2023

Solution:

  • use cancellable node constructor

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Solution:
- use cancellable node constructor
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <[email protected]>
go.mod Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #288 (ea38254) into release/v0.20.x-cronos (0ea7b86) will decrease coverage by 0.04%.
The diff coverage is 25.00%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           release/v0.20.x-cronos     #288      +/-   ##
==========================================================
- Coverage                   52.56%   52.52%   -0.04%     
==========================================================
  Files                         113      113              
  Lines                       11073    11091      +18     
==========================================================
+ Hits                         5820     5826       +6     
- Misses                       5006     5017      +11     
- Partials                      247      248       +1     
Impacted Files Coverage Δ
rpc/namespaces/ethereum/eth/filters/api.go 0.00% <0.00%> (ø)
x/evm/types/utils.go 62.16% <30.76%> (-10.57%) ⬇️

@yihuang yihuang requested a review from mmsqe June 22, 2023 13:56
server/start.go Outdated Show resolved Hide resolved
@yihuang yihuang requested a review from mmsqe June 22, 2023 14:13
Copy link
Collaborator

@mmsqe mmsqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we could backport this refactor

@yihuang
Copy link
Collaborator Author

yihuang commented Jun 23, 2023

not sure if we could backport this refactor

We can reuse sdk StartCmd in newer version

@yihuang yihuang merged commit 4774460 into crypto-org-chain:release/v0.20.x-cronos Jun 23, 2023
@yihuang yihuang deleted the release/v0.20.x-cronos branch June 23, 2023 03:40
mmsqe added a commit that referenced this pull request Sep 6, 2023
* Problem: abci handshake is not shutdown gracefully

Solution:
- use cancellable node constructor

* Update CHANGELOG.md



* fix grpc-only

* better app close

* log error

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: yihuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants