Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: memiavl is not integrated in production version #984

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Apr 20, 2023

Solution:

  • experimental integration of memiavl into v1.0.x
  • removed versiondb/memiavl module, use the standalone memiavl package on main branch directly.
  • mainly for internal testing on production chain, should have no side-effect if don't turn if on.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner April 20, 2023 06:28
@yihuang yihuang requested review from JayT106 and calvinaco and removed request for a team April 20, 2023 06:28
@yihuang yihuang marked this pull request as draft April 20, 2023 06:28
CHANGELOG.md Outdated Show resolved Hide resolved
Solution:
- experimental integration of memiavl into v1.0.x
@yihuang yihuang marked this pull request as ready for review April 20, 2023 07:05
@yihuang yihuang requested a review from mmsqe April 20, 2023 07:05
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #984 (25f28e8) into release/v1.0.x (67b0c61) will decrease coverage by 5.23%.
The diff coverage is 18.60%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/v1.0.x     #984      +/-   ##
==================================================
- Coverage           36.71%   31.49%   -5.23%     
==================================================
  Files                  53       47       -6     
  Lines                3908     3312     -596     
==================================================
- Hits                 1435     1043     -392     
+ Misses               2306     2166     -140     
+ Partials              167      103      -64     
Impacted Files Coverage Δ
versiondb/client/restore_app_db.go 0.00% <0.00%> (ø)
versiondb/client/verify.go 0.00% <0.00%> (ø)
versiondb/client/changeset.go 43.83% <100.00%> (ø)
versiondb/client/convert_to_sst.go 29.23% <100.00%> (ø)

@yihuang yihuang merged commit 53cc988 into crypto-org-chain:release/v1.0.x Apr 20, 2023
Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants