Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: github workflows out of date #1108

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Feb 4, 2025

Solution:

  • update upload-artifact to v4

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- update upload-artifact to v4
@yihuang yihuang requested a review from a team as a code owner February 4, 2025 06:16
@yihuang yihuang requested a review from mmsqe February 4, 2025 06:16
@yihuang yihuang enabled auto-merge February 4, 2025 06:18
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.75%. Comparing base (9d69185) to head (41670b4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1108   +/-   ##
=======================================
  Coverage   31.75%   31.75%           
=======================================
  Files          93       93           
  Lines       17026    17026           
=======================================
  Hits         5406     5406           
  Misses      10678    10678           
  Partials      942      942           
Flag Coverage Δ
integration_tests 23.91% <ø> (ø)
integration_tests_byzantine 10.95% <ø> (ø)
integration_tests_gov 11.20% <ø> (ø)
integration_tests_grpc 11.20% <ø> (ø)
integration_tests_ibc 26.51% <ø> (ø)
integration_tests_ledger 11.18% <ø> (ø)
integration_tests_slow 11.18% <ø> (ø)
integration_tests_solomachine 10.98% <ø> (ø)
integration_tests_upgrade 11.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yihuang yihuang added this pull request to the merge queue Feb 4, 2025
Merged via the queue into crypto-org-chain:master with commit 529aaec Feb 4, 2025
30 of 32 checks passed
@yihuang yihuang deleted the fix-workflows branch February 4, 2025 06:52
yihuang added a commit to yihuang/chain-main that referenced this pull request Feb 4, 2025
yihuang added a commit that referenced this pull request Feb 4, 2025
* Problem: github workflows out of date (backport #1108)

Solution:
- update upload-artifact to v4

* fix hermes build

* Revert "fix hermes build"

This reverts commit 5dac4e5.

* ibc-rs -> hermes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants