Rustfmt macros #22
Merged
Rustfmt macros #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Script `rustfmt-quote.py` is stupid but it works. I have tried to write it in Bash, but it is too slow. The reason to choose Python is that it is built-in in most system. The script first extracts the code between `quote!` and replace the macro variables in it. Then it surrounds the code in the correct context, and run `rustfmt` against it. However, some macro code still fails to pass `rustfmt`, so a blacklist is used to skip these kinds of code.
doitian
force-pushed
the
rustfmt-macros
branch
from
4be49db to
cbab600
Compare
chaoticlonghair
approved these changes
Dec 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script
rustfmt-quote.pyis stupid but it works.I have tried to write it in Bash, but it is too slow. The reason to choose Python is that it is built-in in most system.
The script first extracts the code between
quote!and replace the macro variables in it.Then it surrounds the code in the correct context, and run
rustfmtagainst it.However, some macro code still fails to pass
rustfmt, so a blacklist is used to skip these kinds of code.