This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
XDK: Convert line endings from DOS to Unix. #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the presubmit checks that were complaining about wrong line endings (CRLF instead of just LF) in the xdk-* files, dating back from when they were added to the tree. `git blame' still works fine if passed the "-w" option (ignore whitespace changes).
|
@elvin-nnov @huningxin |
|
Testing patch series with rakuco/v8-crosswalk@b6cb3b2 as its head.
|
|
LGTM. Thanks for the fixing. |
|
LGTM. Thanks for fix |
|
Thanks for the fix and review. I am going to merge it. |
huningxin
added a commit
that referenced
this pull request
Dec 2, 2014
XDK: Convert line endings from DOS to Unix.
mrunalk
pushed a commit
that referenced
this pull request
Jun 11, 2016
Merged 4892cd6 [turbofan] Add a CHECK for max node input count BUG=chromium:582702 LOG=N [email protected] Review URL: https://codereview.chromium.org/2023893002 . Cr-Commit-Position: refs/branch-heads/5.1@{#67} Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1} Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
rakuco
pushed a commit
that referenced
this pull request
Sep 21, 2016
…mple FP aliasing. - Changes ... Revision: 4b76dc8 BUG=v8:4124,chromium:644742 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Review-Url: https://codereview.chromium.org/2316303007 Cr-Commit-Position: refs/branch-heads/5.3@{#67} Cr-Branched-From: 820a23a-refs/heads/5.3.332@{#2} Cr-Branched-From: 37538cb-refs/heads/master@{#37308}
rakuco
pushed a commit
that referenced
this pull request
Oct 21, 2016
…ges. Revision: 9a0109d BUG=chromium:645438 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Review URL: https://codereview.chromium.org/2436763002 . Cr-Commit-Position: refs/branch-heads/5.4@{#67} Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2} Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
imreotto
pushed a commit
to tenta-browser/v8-crosswalk
that referenced
this pull request
Sep 4, 2017
Revision: 6803eef BUG=v8:6435 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected], [email protected] Change-Id: I36d1c19324f51dde6356a8db2383036cc5f77c24 Reviewed-on: https://chromium-review.googlesource.com/523006 Reviewed-by: Adam Klein <[email protected]> Commit-Queue: Ali Ijaz Sheikh <[email protected]> Cr-Commit-Position: refs/branch-heads/5.9@{crosswalk-project#67} Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{crosswalk-project#1} Cr-Branched-From: 70ad237-refs/heads/master@{#44591}
asifhisam
pushed a commit
to asifhisam/v8-crosswalk
that referenced
this pull request
Sep 9, 2019
Loading the map, performing a side-effect, and then using the stored pointer for the fast-path check is another antipattern that can lead to unintended shapes on the fast path. Backmerge of commit db61537. BUG=chromium:709029 [email protected] NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2818683005 Cr-Commit-Position: refs/branch-heads/5.8@{crosswalk-project#67} Cr-Branched-From: eda659c-refs/heads/5.8.283@{crosswalk-project#1} Cr-Branched-From: 4310cd0-refs/heads/master@{#43429}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the presubmit checks that were complaining about wrong line
endings (CRLF instead of just LF) in the xdk-* files, dating back from
when they were added to the tree.
`git blame' still works fine if passed the "-w" option (ignore
whitespace changes).