This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Extend CPU profiler with mapping ticks to source lines #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing patch series with eleskine/v8-crosswalk@089ec674181058acfe9fabffcb685e8071f829dc as its head.
|
This patch applies changes from https://codereview.chromium.org/682143003/ review. The code introduces instruction_start attribute to CodeEntry class. Therefore each code entry has at least one instruction mapped to a source location. This patch also fixes fast/events/window-onerror-02.html chromium test as well as following v8-crosswalk debug tests: cctest/test-api/CallICFastApi_SimpleSignature_Miss2WithProfiler cctest/test-api/CallICFastApi_SimpleSignature_TypeErrorWithProfiler cctest/test-api/InterceptorCallICFastApi_SimpleSignature_Miss3WithProfiler cctest/test-api/InterceptorCallICFastApi_SimpleSignature_TypeErrorWithProfiler cctest/test-profile-generator/NoSamples cctest/test-profile-generator/RecordTickSample cctest/test-profile-generator/SampleIds
|
LGTM. Thanks for the PR. |
rakuco
pushed a commit
that referenced
this pull request
Nov 1, 2014
Extend CPU profiler with mapping ticks to source lines
|
Merged, remember you have to roll |
mrunalk
pushed a commit
that referenced
this pull request
Jun 11, 2016
Merged cc71837 [builtins] Migrate String.fromCharCode to C++. [email protected] BUG=chromium:609831 LOG=N Review URL: https://codereview.chromium.org/2010473005 . Cr-Commit-Position: refs/branch-heads/5.1@{#59} Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1} Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
rakuco
pushed a commit
that referenced
this pull request
Sep 21, 2016
Merged: [ia32] Fixes a bug in cmpw. Revision: 588e15c Merged: [ia32] Fixes a wrong use of Operand in a test. Revision: c0d4bb8 BUG=621926 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Review-Url: https://codereview.chromium.org/2311793002 Cr-Commit-Position: refs/branch-heads/5.3@{#59} Cr-Branched-From: 820a23a-refs/heads/5.3.332@{#2} Cr-Branched-From: 37538cb-refs/heads/master@{#37308}
rakuco
pushed a commit
that referenced
this pull request
Oct 17, 2016
Revision: d008b9e BUG=chromium:635769 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Review URL: https://codereview.chromium.org/2368183005 . Cr-Commit-Position: refs/branch-heads/5.4@{#59} Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2} Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
imreotto
pushed a commit
to tenta-browser/v8-crosswalk
that referenced
this pull request
Sep 4, 2017
…ethod It was merged with incorrect indentation at one of the line. Let's fix presubmit check. Bug: none Change-Id: I2259c0624036b0325dc038e481ab223323dcbd7e Reviewed-on: https://chromium-review.googlesource.com/509536 Reviewed-by: Aleksey Kozyatinskiy <[email protected]> Cr-Commit-Position: refs/branch-heads/5.9@{crosswalk-project#59} Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{crosswalk-project#1} Cr-Branched-From: 70ad237-refs/heads/master@{#44591}
asifhisam
pushed a commit
to asifhisam/v8-crosswalk
that referenced
this pull request
Sep 9, 2019
Cr-Commit-Position: refs/branch-heads/5.8@{crosswalk-project#59}
Cr-Branched-From: eda659c-refs/heads/5.8.283@{crosswalk-project#1}
Cr-Branched-From: 4310cd0-refs/heads/master@{#43429}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch applies changes from https://codereview.chromium.org/682143003/ review.
The code introduces instruction_start attribute to CodeEntry class.
Therefore each code entry has at least one instruction mapped to a source location.
This patch also fixes fast/events/window-onerror-02.html chromium test as well as
following v8-crosswalk debug tests:
cctest/test-api/CallICFastApi_SimpleSignature_Miss2WithProfiler
cctest/test-api/CallICFastApi_SimpleSignature_TypeErrorWithProfiler
cctest/test-api/InterceptorCallICFastApi_SimpleSignature_Miss3WithProfiler
cctest/test-api/InterceptorCallICFastApi_SimpleSignature_TypeErrorWithProfiler
cctest/test-profile-generator/NoSamples
cctest/test-profile-generator/RecordTickSample
cctest/test-profile-generator/SampleIds