XDK heap profiler collector #55

elvin-n · 2014-10-16T14:30:07Z

This is a V8 part of the XDK heap profiler patch

crosswalk-trybot · 2014-10-16T14:30:09Z

Testing patch series with elvin-n/v8-crosswalk@fa97d6a as its head.

Bot	Status
V8 Linux ARM	[FAILED 💔](https://build.crosswalk-project.org/try/builders/V8 Linux ARM/builds/33)
V8 Linux x64	[FAILED 💔](https://build.crosswalk-project.org/try/builders/V8 Linux x64/builds/35)
V8 Linux ia32	[FAILED 💔](https://build.crosswalk-project.org/try/builders/V8 Linux ia32/builds/36)

huningxin · 2014-10-17T01:58:06Z

Hi @elvin-nnov , thanks for the PR. Could you please fix the coding style errors reported by the bots first? Thanks.

crosswalk-trybot · 2014-10-20T16:32:55Z

Testing patch series with elvin-n/v8-crosswalk@2ea06f7 as its head.

Bot	Status
V8 Linux ARM	[FAILED 💔](https://build.crosswalk-project.org/try/builders/V8 Linux ARM/builds/35)
V8 Linux x64	[FAILED 💔](https://build.crosswalk-project.org/try/builders/V8 Linux x64/builds/37)
V8 Linux ia32	[FAILED 💔](https://build.crosswalk-project.org/try/builders/V8 Linux ia32/builds/38)

crosswalk-trybot · 2014-10-20T19:29:08Z

Testing patch series with elvin-n/v8-crosswalk@d9595ec as its head.

Bot	Status
V8 Linux ARM	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/V8 Linux ARM/builds/36)
V8 Linux x64	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/V8 Linux x64/builds/38)
V8 Linux ia32	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/V8 Linux ia32/builds/39)

rakuco · 2014-10-21T12:18:39Z

You need to squash all those 3 commits together now.

elvin-n · 2014-10-22T10:28:49Z

I cannot do this. Each time I squash these three commits together 'git status' says
On branch master
Your branch and 'origin/master' have diverged,
and have 1 and 3 different commits each, respectively.
(use "git pull" to merge the remote branch into yours)
And after the pull git takes three comits from the origin and the situation is repeated one more time - I squash them already 5 commits (3 from origin, one which was squashed, 1 - message about merge), origin and local are diverged, I pull,squash, again diverged, etc, etc.

If you can help, I would appreciate

rakuco · 2014-10-22T10:54:33Z

git rebase -i <base-commit>
# squash, squash
git push -f my-origin my-branch

It is fine if your branch diverges, that's exactly what you did with your squashing.

crosswalk-trybot · 2014-10-22T11:22:21Z

Testing patch series with elvin-n/v8-crosswalk@ac2caad as its head.

Bot	Status
V8 Linux ARM	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/V8 Linux ARM/builds/38)
V8 Linux ia32	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/V8 Linux ia32/builds/41)
V8 Linux x64	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/V8 Linux x64/builds/40)

elvin-n · 2014-10-22T11:26:41Z

Yes, the key '-f' make magic. Danger key...
Thank you for help

rakuco · 2014-10-22T13:06:58Z

ping @huningxin @fenghaitao

halton · 2014-10-22T13:26:16Z

@rakuco just let u know, @fenghaitao no longer work on crosswalk projects.

rakuco · 2014-10-22T13:38:02Z

right, is there anyone besides Ningxin who should be pinged for V8 reviews now?

huningxin · 2014-10-23T02:01:58Z

I attended the design review of this feature. I am going to review the patch today. Thanks.

huningxin · 2014-10-23T07:45:38Z

src/heap-profiler.cc

+    allocation_tracker_xdk_->CollectFreedObjects();
+    OutputStream::WriteResult result =
+        allocation_tracker_xdk_->SendChunk(stream);
+    // TODO(amalyshe): it's interesting who can return kAbbort and when and


typo kAbbort?

huningxin · 2014-10-23T08:17:50Z

src/xdk-utils.cc

+
+
+PostCollectedInfo* RuntimeInfo::AddPreCollectionInfo(Address addr,
+    unsigned size) {


argument indentation.

crosswalk-trybot · 2014-10-27T14:55:13Z

Testing patch series with elvin-n/v8-crosswalk@3fe152c as its head.

Bot	Status
V8 Linux ARM	[FAILED 💔](https://build.crosswalk-project.org/try/builders/V8 Linux ARM/builds/39)
V8 Linux x64	[FAILED 💔](https://build.crosswalk-project.org/try/builders/V8 Linux x64/builds/41)
V8 Linux ia32	[FAILED 💔](https://build.crosswalk-project.org/try/builders/V8 Linux ia32/builds/42)

crosswalk-trybot · 2014-10-27T15:01:01Z

Testing patch series with elvin-n/v8-crosswalk@f63800e as its head.

Bot	Status
V8 Linux ARM	[FAILED 💔](https://build.crosswalk-project.org/try/builders/V8 Linux ARM/builds/40)
V8 Linux x64	[FAILED 💔](https://build.crosswalk-project.org/try/builders/V8 Linux x64/builds/42)
V8 Linux ia32	[FAILED 💔](https://build.crosswalk-project.org/try/builders/V8 Linux ia32/builds/43)

crosswalk-trybot · 2014-10-27T15:43:40Z

Testing patch series with elvin-n/v8-crosswalk@6e58545 as its head.

Bot	Status
V8 Linux ARM	[FAILED 💔](https://build.crosswalk-project.org/try/builders/V8 Linux ARM/builds/41)
V8 Linux x64	[FAILED 💔](https://build.crosswalk-project.org/try/builders/V8 Linux x64/builds/43)
V8 Linux ia32	[FAILED 💔](https://build.crosswalk-project.org/try/builders/V8 Linux ia32/builds/44)

crosswalk-trybot · 2014-10-27T17:00:09Z

Testing patch series with elvin-n/v8-crosswalk@5db4b09 as its head.

Bot	Status
V8 Linux ARM	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/V8 Linux ARM/builds/42)
V8 Linux x64	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/V8 Linux x64/builds/44)
V8 Linux ia32	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/V8 Linux ia32/builds/45)

crosswalk-trybot · 2014-10-28T14:13:30Z

Testing patch series with elvin-n/v8-crosswalk@66b6f26 as its head.

Bot	Status
V8 Linux ARM	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/V8 Linux ARM/builds/43)
V8 Linux x64	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/V8 Linux x64/builds/45)
V8 Linux ia32	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/V8 Linux ia32/builds/46)

huningxin · 2014-10-29T01:03:32Z

LGTM. Thanks for the efforts.

rakuco · 2014-10-29T10:17:32Z

Merging. The next step is to roll the dependency in Crosswalk -- you have to edit DEPS.xwalk there and change the SHA1 hash we're using for v8-crosswalk. Please make sure you take a look at the previous commits to that file, the format we use for the commits there is quite strict (we indicate which commits are being added with the SHA1 change, they can be obtained via git log --oneline --no-decorate). See crosswalk-project/crosswalk#2532 for a recent example (this was a blink-crosswalk roll, but the same rules apply to v8-crosswalk).

XDK heap profiler collector

[email protected] BUG=v8:4909 LOG=n Review URL: https://codereview.chromium.org/1945283002 . Cr-Commit-Position: refs/branch-heads/5.0@{#55} Cr-Branched-From: ad16e6c-refs/heads/5.0.71@{#1} Cr-Branched-From: bd9df50-refs/heads/master@{#34215}

NOTRY=true NOPRESUBMIT=true [email protected] Review-Url: https://codereview.chromium.org/2001043002 Cr-Commit-Position: refs/branch-heads/5.1@{#55} Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1} Cr-Branched-From: 03953f5-refs/heads/master@{#35282}

Revision: d8792ab NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected], [email protected] BUG= Review-Url: https://codereview.chromium.org/2302003002 Cr-Commit-Position: refs/branch-heads/5.3@{#55} Cr-Branched-From: 820a23a-refs/heads/5.3.332@{#2} Cr-Branched-From: 37538cb-refs/heads/master@{#37308}

Revision: 4dab7b5 BUG=chromium:647887 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected], [email protected] Review URL: https://codereview.chromium.org/2364843002 . Cr-Commit-Position: refs/branch-heads/5.4@{#55} Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2} Cr-Branched-From: ad07b49-refs/heads/master@{#38841}

Revision: b056073 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Bug: Change-Id: Ib1cce0e52d3f0d413109bf0b7293b1c61117e6e8 Reviewed-on: https://chromium-review.googlesource.com/506749 Reviewed-by: Junliang Yan <[email protected]> Commit-Queue: Junliang Yan <[email protected]> Cr-Commit-Position: refs/branch-heads/5.9@{crosswalk-project#55} Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{crosswalk-project#1} Cr-Branched-From: 70ad237-refs/heads/master@{#44591}

This fixes behavior for HeapNumber {index} arguments passed to AdvanceStringIndex. Previously, we'd blindly treat {index} as a Smi. Passing a HeapNumber instead would result in a Smi addition on the tagged HeapNumber pointer. Backmerge of commit ed5496f. BUG=chromium:709015 NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2808033002 Cr-Commit-Position: refs/branch-heads/5.8@{crosswalk-project#55} Cr-Branched-From: eda659c-refs/heads/5.8.283@{crosswalk-project#1} Cr-Branched-From: 4310cd0-refs/heads/master@{#43429}

huningxin reviewed Oct 23, 2014
View reviewed changes

src/xdk-utils.cc

PostCollectedInfo* RuntimeInfo::AddPreCollectionInfo(Address addr,

unsigned size) {

Copy link

Contributor

huningxin Oct 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argument indentation.

XDK heap profiler collector

66b6f26

rakuco pushed a commit that referenced this pull request Oct 29, 2014

Merge pull request #55 from elvin-nnov/master

03d8b6c

XDK heap profiler collector

rakuco merged commit 03d8b6c into crosswalk-project:master Oct 29, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

XDK heap profiler collector #55

XDK heap profiler collector #55

elvin-n commented Oct 16, 2014

crosswalk-trybot commented Oct 16, 2014

huningxin commented Oct 17, 2014

crosswalk-trybot commented Oct 20, 2014

crosswalk-trybot commented Oct 20, 2014

rakuco commented Oct 21, 2014

elvin-n commented Oct 22, 2014

rakuco commented Oct 22, 2014

crosswalk-trybot commented Oct 22, 2014

elvin-n commented Oct 22, 2014

rakuco commented Oct 22, 2014

halton commented Oct 22, 2014

rakuco commented Oct 22, 2014

huningxin commented Oct 23, 2014

huningxin Oct 23, 2014

huningxin Oct 23, 2014

crosswalk-trybot commented Oct 27, 2014

crosswalk-trybot commented Oct 27, 2014

crosswalk-trybot commented Oct 27, 2014

crosswalk-trybot commented Oct 27, 2014

crosswalk-trybot commented Oct 28, 2014

huningxin commented Oct 29, 2014

rakuco commented Oct 29, 2014



		PostCollectedInfo* RuntimeInfo::AddPreCollectionInfo(Address addr,
		unsigned size) {

XDK heap profiler collector #55

XDK heap profiler collector #55

Conversation

elvin-n commented Oct 16, 2014

crosswalk-trybot commented Oct 16, 2014

huningxin commented Oct 17, 2014

crosswalk-trybot commented Oct 20, 2014

crosswalk-trybot commented Oct 20, 2014

rakuco commented Oct 21, 2014

elvin-n commented Oct 22, 2014

rakuco commented Oct 22, 2014

crosswalk-trybot commented Oct 22, 2014

elvin-n commented Oct 22, 2014

rakuco commented Oct 22, 2014

halton commented Oct 22, 2014

rakuco commented Oct 22, 2014

huningxin commented Oct 23, 2014

huningxin Oct 23, 2014

Choose a reason for hiding this comment

huningxin Oct 23, 2014

Choose a reason for hiding this comment

crosswalk-trybot commented Oct 27, 2014

crosswalk-trybot commented Oct 27, 2014

crosswalk-trybot commented Oct 27, 2014

crosswalk-trybot commented Oct 27, 2014

crosswalk-trybot commented Oct 28, 2014

huningxin commented Oct 29, 2014

rakuco commented Oct 29, 2014