Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Commit

Permalink
[GN] Define USE_EABI_HARDFLOAT=1 when arm_float_abi=="hard".
Browse files Browse the repository at this point in the history
Add this define to the config used for mksnapshot. This fixes a bug
where certain applications would fail at runtime on Chromecast.

BUG=592660
LOG=Y
Bug: internal b/27495984

Test: Formerly broken Cast apps load and run as expected.

Review URL: https://codereview.chromium.org/1839763003

Cr-Commit-Position: refs/heads/master@{#35183}
  • Loading branch information
slan authored and Commit bot committed Apr 1, 2016
1 parent eb5fe0d commit 86357d5
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ config("toolchain") {
cflags = []

# TODO(jochen): Add support for arm subarchs, mips, mipsel, mips64el.

if (v8_target_arch == "arm") {
defines += [ "V8_TARGET_ARCH_ARM" ]
if (current_cpu == "arm") {
Expand All @@ -170,8 +169,13 @@ config("toolchain") {
"CAN_USE_ARMV7_INSTRUCTIONS",
"CAN_USE_VFP3_INSTRUCTIONS",
"CAN_USE_VFP32DREGS",
"USE_EABI_HARDFLOAT=0",
]

if (arm_float_abi == "hard") {
defines += [ "USE_EABI_HARDFLOAT=1" ]
} else if (arm_float_abi == "softfp") {
defines += [ "USE_EABI_HARDFLOAT=0" ]
}
}

# TODO(jochen): Add support for arm_test_noprobe.
Expand Down

0 comments on commit 86357d5

Please sign in to comment.