-
Notifications
You must be signed in to change notification settings - Fork 653
[Android] Fix build errors that are introduced by rebasing to version 31 #824
Conversation
@yongsheng @wang16 PTAL, thanks |
@wang16 in https://github.com/crosswalk-project/chromium-crosswalk crosswalk-project/chromium-crosswalk@508c5aa |
@kenchris updated the commit log to explain why some code/methed are removed. |
ok lgtm |
commit log typo: |
… 31. Some changes that have been made in upstream version 31 break XWalk for Android. Fix the break in XWalk, including: * Replacing AndroidBrowserProcess to BrowserStartupController. * Changes in DevToolsServer/JavaScriptDialogManager. * Some namespace changes. * Removing override method ContentVideoViewClient.keepScreenOn as interface has changed. * Removing kEnableExperimentalWebGL switch since this switch is no longer used from version 31 for Android port. BUG= TEST=Build
Trybot DashboardBuilding status:Finished the build of the PATCH in this pull requestRebuild the failed bots you want!Tue Oct 08 2013 19:25:09 GMT+0800 (CST) [xwalk_linux] Failed LOGS: build exception [runhooks] Select the bots:
Start the building:
|
Fix in https://github.com/crosswalk-project/chromium-crosswalk should also be merged to make build pass. https://github.com/sqliu/chromium-crosswalk/tree/revert-fixing-of-context |
Just to make sure I'm understanding it all! I can simply revert crosswalk-project/chromium-crosswalk@508c5aa now and then apply this patch to fix Android? Will there be any other follow up patch for chromium-crosswalk after that? |
According to http://src.chromium.org/viewvc/chrome?view=revision&revision=215135, the switch has been removed, but the feature has not just been turned on all the time: one must pass |
@rakuco I'm +1 to merge this and open an issue for the Android team to handle --ignore-gpu-blacklist later. |
[Android] Fix build errors that are introduced by rebasing to version 31
@kenchris yes, it's enabled by default on a device only when if its graphic driver can meet the below requirements: |
Some changes that have been made in upstream version 31 break XWalk for Android.
Fix the break in XWalk, including:
version 31 for Android port.
BUG=
TEST=Build