This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Android] Allow constructor of Notifications on Android. #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We support notifications in Android but upstream doesn't so we should make sure they are enabled. We should really consider if the "desktop" notifications are the way forward for us in Android now that we have ServiceWorker and push notifications. https://codereview.chromium.org/920153002 BUG=XWALK-3653
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2015
[Android] Allow constructor of Notifications on Android.
rakuco
pushed a commit
that referenced
this pull request
Apr 30, 2015
We attempt to match Windows behaviour for the value of VKEY on a keystroke. Some XKB layouts generate characters for AltGr+key combinations that are not present in the reference (Windows-based) sources, which led to mismtaches in the mappings, and incorrect VKEY values for those keys. To avoid this, we match on any AltGr+key result in cases the reference has none. The corresponding test is revised to use a valid dummy character for those cases, rather than 'NoSymbol'. TBR=spang BUG=480529 Review URL: https://codereview.chromium.org/1100393005 Cr-Commit-Position: refs/heads/master@{#326695} (cherry picked from commit e63d52e) Review URL: https://codereview.chromium.org/1109873003 Cr-Commit-Position: refs/branch-heads/2357@{#235} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
rakuco
pushed a commit
that referenced
this pull request
Aug 13, 2015
This patch denies the request if there is no response when GeolocationPermission.Callback object is gc-ed. TBR=boliu BUG=513752 NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1267103003 Cr-Commit-Position: refs/heads/master@{#341760} (cherry picked from commit 97d22bb) Review URL: https://codereview.chromium.org/1277563002 Cr-Commit-Position: refs/branch-heads/2454@{#235} Cr-Branched-From: 12bfc33-refs/heads/master@{#338390}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
While this probably isn't the principle infobar crash, it does have a few bad smells: 1) InfoBarDelegate's already have an infobar() accessor. Use that instead of a cached tab instance. 2) Many places in infobar code that handle user events check the context to ensure they're still valid before handling them but this didn't. BUG=481758 TBR=acleung Review URL: https://codereview.chromium.org/1322063003 Cr-Commit-Position: refs/heads/master@{#347017} (cherry picked from commit 4d97826) Review URL: https://codereview.chromium.org/1340693002 . Cr-Commit-Position: refs/branch-heads/2490@{#235} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
BUG=564028 Review URL: https://codereview.chromium.org/1487373003 Cr-Commit-Position: refs/heads/master@{#362749} (cherry picked from commit 5964bae) Review URL: https://codereview.chromium.org/1495033003 . Cr-Commit-Position: refs/branch-heads/2564@{#235} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
…first one). Most of our painting-related operations take place after fragmentation, i.e. via PaintLayerPainter::paintFragmentWithPhase(). All such operations can just sit back and relax and not worry about fragmentation, since translation and clipping for a given fragmentainer (column) has already taken place. This is not the case for filters, though. They are set up before fragmentation. Therefore, we need to make the bounding box of the layer visual (convert out of the flow thread coordinate space) on our own. We now do this specifically for filters, or we'd upset other parts of the code, such as clip path. BUG=530074 [email protected] Review URL: https://codereview.chromium.org/1645583002 Cr-Commit-Position: refs/heads/master@{#371808} (cherry picked from commit 17e31b8) Review URL: https://codereview.chromium.org/1656213002 . Cr-Commit-Position: refs/branch-heads/2623@{#235} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#235}
Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
BUG=613971 Review-Url: https://codereview.chromium.org/2011283002 Cr-Commit-Position: refs/heads/master@{#397064} (cherry picked from commit 64ad58e) Review URL: https://codereview.chromium.org/2044483002 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#235} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
Correctly select voice interaction OOBE flow and runtime flow; Update launcher button state after oobe flow; BUG=b:65463229 BUG=b:65463264 TEST=local flash and test [email protected] (cherry picked from commit bc4b8e8) Change-Id: Ibdef7ed5b9b45894fa74c76220d7971c621abb69 Reviewed-on: https://chromium-review.googlesource.com/656577 Commit-Queue: Muyuan Li <[email protected]> Reviewed-by: Luis Hector Chavez <[email protected]> Reviewed-by: Xiyuan Xia <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#500716} Reviewed-on: https://chromium-review.googlesource.com/667901 Reviewed-by: Vladislav Kaznacheev <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#235} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support notifications in Android but upstream doesn't so we
should make sure they are enabled.
We should really consider if the "desktop" notifications are the way
forward for us in Android now that we have ServiceWorker and
push notifications.
https://codereview.chromium.org/920153002
BUG=XWALK-3653