This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Add gyp flag disable_xslt #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, will merge. |
|
We should probably do this for regular crosswalk |
|
@kenchris , good point. We'll include QA to do the regression test, if no big issue found, we'll submit PR to master. Question for you or maybe @darktears , do you think other parts can be promoted to master?
|
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Nov 28, 2014
Split Enterprise.EnrollmentForced off Enterprise.Enrollment histogram. [email protected] BUG=420602 Review URL: https://codereview.chromium.org/633003002 Cr-Commit-Position: refs/heads/master@{#298483} (cherry picked from commit de94b4c) Review URL: https://codereview.chromium.org/666113002 Cr-Commit-Position: refs/branch-heads/2171@{crosswalk-project#208} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
rakuco
pushed a commit
that referenced
this pull request
Feb 27, 2015
This reverts commit ce03495. BUG=432562 [email protected],[email protected],[email protected] Review URL: https://codereview.chromium.org/892203008 Cr-Commit-Position: refs/branch-heads/2272@{#208} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco
pushed a commit
that referenced
this pull request
Apr 30, 2015
Prevent incorrect OverviewButton hiding states. When exiting Maximize Mode the OverviewButton animates itself hiding. However now any screen rotations occurring during this mode switch are also animated. ScreenRotationAnimator copies the old layers, and deletes them upon the completion of its animation. This can lead to layers being deleted while still animating, without notifying their observers. Update TrayBackgroundView to be notified when observed layers are deleted while animating. TEST=OverviewButtonTrayTest.HideAnimationAlwaysCompletes BUG=476667 [email protected] NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1080633007 Cr-Commit-Position: refs/heads/master@{#326167} (cherry picked from commit 2de2331) Review URL: https://codereview.chromium.org/1091463003 Cr-Commit-Position: refs/branch-heads/2357@{#208} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
This header file was unnecessarily included (and doesn't exist on the branch) BUG=529910 Review URL: https://codereview.chromium.org/1333673004 . Cr-Commit-Position: refs/branch-heads/2490@{#208} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
Instead of throwing errors for SharedWorker secure context mismatches, add in some UseCounters to measure the impact of doing so. BUG=573206 Review URL: https://codereview.chromium.org/1602783005 Cr-Commit-Position: refs/heads/master@{#370429} (cherry picked from commit 67daf6c) Review URL: https://codereview.chromium.org/1656683002 . Cr-Commit-Position: refs/branch-heads/2623@{#208} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
BUG=592058 TEST=InkDropAnimationControllerImplTest.* TEST=InkDropAnimationTest.* TEST=CustomButtonTest.InkDropAfterShowingContextMenu TEST=CustomButtonTest.InkDropAfterTryingToShowContextMenu TEST=Manual Review URL: https://codereview.chromium.org/1757993004 Cr-Commit-Position: refs/heads/master@{#380786} (cherry picked from commit db5c17d) Review URL: https://codereview.chromium.org/1796623002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#208} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
…p to spec. (patchset #1 id:1 of https://codereview.chromium.org/2032143004/ ) Reason for revert: Broke the continuous build because of a missing symbol. https://chromegw.corp.google.com/i/official.desktop.continuous/builders/mac%20beta/builds/3236/steps/compile/logs/stdio FAILED: obj/chrome/browser/ui/cocoa/location_bar/browser_ui.location_bar_view_mac.o ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/ui/cocoa/location_bar/browser_ui.location_bar_view_mac.o.d -DV8_DEPRECATION_WARNINGS -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=269902-1 -DENABLE_RLZ -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_NOTIFICATIONS -DENABLE_TOPCHROME_MD=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_PROD_WALLET_SERVICE=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_HANGOUT_SERVICES_EXTENSION=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DMOJO_USE_SYSTEM_IMPL -DTOOLKIT_VIEWS=1 -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DUSE_CUPS '-DI18N_ADDRESS_VALIDATION_DATA_URL="https://i18napis.appspot.com/ssl-aggregate-address/"' -DI18N_ADDRESSINPUT_USE_BASICTYPES_OVERRIDE=1 -DUSE_LIBPCI=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. -Iobj/chrome/browser_ui.gen -Iobj/chrome/browser_ui.gen/chrome -I../../skia/config -I../../third_party/khronos -I../../gpu -Igen/angle -I../../third_party/WebKit/Source -Igen/chrome -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/dom_distiller_js/dist/proto_gen -Igen/policy -Igen/components -Igen/components/strings -I../../third_party/WebKit -Igen/third_party/WebKit -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../skia/ext -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -I../../third_party/cacheinvalidation/google/cacheinvalidation -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/zlib -Igen/ui/resources -Igen/content/app/resources/ -I../../third_party/libwebm/source -I../../third_party/opus/src/include -I../../third_party/leveldatabase/src/include -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase -I../../third_party/re2/src -I../../v8/include -I../../third_party/google_toolbox_for_mac -I../../third_party/google_toolbox_for_mac/src -I../../third_party/google_toolbox_for_mac/src/AppKit -I../../third_party/google_toolbox_for_mac/src/DebugUtils -I../../third_party/google_toolbox_for_mac/src/Foundation -Igen/ui/views/resources -I../../third_party/libaddressinput/chromium/override -I../../third_party/libaddressinput/src/cpp/include -Igen/third_party/libaddressinput/ -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -O2 -gdwarf-2 -fvisibility=hidden -Werror -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonnull -Wexit-time-destructors -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /b/build/slave/mac_beta/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang -plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors -fcolor-diagnostics -fno-strict-aliasing -fno-standalone-debug -Wobjc-missing-property-synthesis -fobjc-call-cxx-cdtors -c ../../chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm -o obj/chrome/browser/ui/cocoa/location_bar/browser_ui.location_bar_view_mac.o ../../chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:583:29: error: no member named 'GetSecureTextColor' in 'OmniboxViewMac' OmniboxViewMac::GetSecureTextColor(security_level, in_dark_mode); ~~~~~~~~~~~~~~~~^ Original issue's description: > [Mac][Material Design] Bring Omnibox stroke and MD colors up to spec. > > This cl changes the Omnibox's stroke in Incognito mode to match the > recent spec revisions made by sgabriel@. > > Changing to the new spec also required switching other MD colors to the > sRGB color space so that everything matched. The plan was to switch to > sRGB (which is correct - the calibrated space is not) eventually, but > to get the Omnibox to look right, now is the time. > > [email protected],[email protected] > BUG=613749 > > Review-Url: https://codereview.chromium.org/2013183003 > Cr-Commit-Position: refs/heads/master@{#396986} > (cherry picked from commit 7a7f2e3) > > Committed: https://chromium.googlesource.com/chromium/src/+/793018247051e845ad6754e0344f5f892349237f [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=613749 Review-Url: https://codereview.chromium.org/2035153002 Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#208} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
…y the one that created it. BUG=763448 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ie80eb595ef597618e8b8282c3224e243a9b2f2fe Reviewed-on: https://chromium-review.googlesource.com/658758 Reviewed-by: Fady Samuel <[email protected]> Commit-Queue: John Abd-El-Malek <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#500969}(cherry picked from commit 9c909e1) Reviewed-on: https://chromium-review.googlesource.com/665677 Reviewed-by: John Abd-El-Malek <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#208} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.