This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
.gitignore: Ignore src/third_party/khronos/CL. #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We started checking out this directory with Crosswalk PR#2426, but since we do not have it in .gitignore the directory ends up being removed every time we run gclient sync.
|
Testing patch series with rakuco/chromium-crosswalk@22479b2 as its head.
|
|
lgtm, thanks for your patch. |
rakuco
pushed a commit
that referenced
this pull request
Oct 7, 2014
.gitignore: Ignore src/third_party/khronos/CL.
junmin-zhu
pushed a commit
to junmin-zhu/chromium-crosswalk
that referenced
this pull request
Oct 8, 2014
BUG=409104 b/17294369 [email protected] Review URL: https://codereview.chromium.org/510023003 Cr-Commit-Position: refs/heads/master@{#293015} Review URL: https://codereview.chromium.org/534863002 Cr-Commit-Position: refs/branch-heads/2125@{crosswalk-project#195} Cr-Branched-From: b68026d-refs/heads/master@{#290040}
mrunalk
pushed a commit
that referenced
this pull request
Jan 27, 2015
If a deletion happens while a commit is in flight, we should make sure that the deletion makes it to the server. Previously we were over-aggressively assuming that the entity was unknown by the server and therefore the deletion was unnecessary. BUG=426865 Review URL: https://codereview.chromium.org/729523003 Cr-Commit-Position: refs/heads/master@{#304462} (cherry picked from commit 87192fc) Review URL: https://codereview.chromium.org/754773005 Cr-Commit-Position: refs/branch-heads/2214@{#195} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
rakuco
pushed a commit
that referenced
this pull request
Mar 12, 2015
BUG=461604,435358 TEST=manual Review URL: https://codereview.chromium.org/969403002 Cr-Commit-Position: refs/heads/master@{#318878} (cherry picked from commit dd6f709) Review URL: https://codereview.chromium.org/991333002 Cr-Commit-Position: refs/branch-heads/2311@{#195} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco
pushed a commit
that referenced
this pull request
Apr 30, 2015
This reverts commit dc948e4. [email protected] BUG=479829,475894 Review URL: https://codereview.chromium.org/1095323005 Cr-Commit-Position: refs/branch-heads/2357@{#195} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
This works, in that it stops it from getting shown over the first page. An additional problem on Win10 is that when the user switches to the NTP (as that's the default setup on Win10: [Getting started, NTP]) the bubble won't show because the Observer only watches navigations. Once *another* new tab is created or the user navigates, then it'll show up. This is at least an improvement. [email protected] BUG=521572 Review URL: https://codereview.chromium.org/1330553003 Cr-Commit-Position: refs/heads/master@{#347515} (cherry picked from commit dd9b9d3) Review URL: https://codereview.chromium.org/1310883011 . Cr-Commit-Position: refs/branch-heads/2490@{#195} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
BUG=552558 TEST=TraceEventAndroidTest.WriteToATrace > Review URL: https://codereview.chromium.org/1490763006 > Cr-Commit-Position: refs/heads/master@{#362574} [email protected] Review URL: https://codereview.chromium.org/1493583002 . Cr-Commit-Position: refs/branch-heads/2564@{#195} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
BUG=573289 Review URL: https://codereview.chromium.org/1601383002 Cr-Commit-Position: refs/heads/master@{#370794} (cherry picked from commit fb0a421) Review URL: https://codereview.chromium.org/1648413002 . Cr-Commit-Position: refs/branch-heads/2623@{#195} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
There was code in the PushEvent that would create an empty data object even when no data was available. Remove it, and add an end-to-end test. BUG=593454 Review URL: https://codereview.chromium.org/1784583002 Cr-Commit-Position: refs/heads/master@{#380258} (cherry picked from commit 72d7385) Review URL: https://codereview.chromium.org/1786733003 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#195} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
This cl brings the bookmark hover state appearance in various places, the padding between buttons, and the layout of folder buttons within folder menus up to spec. [email protected] BUG=613279,615224,615163,613086 Committed: https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133 Cr-Commit-Position: refs/heads/master@{#396195} Review-Url: https://codereview.chromium.org/2013523005 Cr-Commit-Position: refs/heads/master@{#396851} (cherry picked from commit 384032d) Review URL: https://codereview.chromium.org/2034813002 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#195} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
This metric is used only pre-O. On O, we need to look for notifications being blocked at the system level instead. Bug: 761359 Change-Id: Ia7f18a5abfc1de5b3327b5521f6821f057f3e32d Reviewed-on: https://chromium-review.googlesource.com/649106 Commit-Queue: Chris Pickel <[email protected]> Reviewed-by: Peter Conn <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#500560}(cherry picked from commit cf340a2) Reviewed-on: https://chromium-review.googlesource.com/663161 Reviewed-by: Chris Pickel <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#195} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started checking out this directory with Crosswalk PR#2426, but since
we do not have it in .gitignore the directory ends up being removed
every time we run gclient sync.