Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Commit

Permalink
Fix regression where extension action icons may not be displayed prop…
Browse files Browse the repository at this point in the history
…erly

A BrowserActionView can set its image view for the first time in UpdateState(),
but UpdateState() only called SchedulePaint(), and not Layout() (which is
necessary for the image). Coincidentally, with all the Layout()s called on
BrowserActionsContainer, this only manifested itself in Windows 8 Metro Mode
(likely because race conditions caused the image to be updated after all calls
to Layout()).

BUG=409782

Review URL: https://codereview.chromium.org/608013002

Cr-Commit-Position: refs/heads/master@{#297069}
  • Loading branch information
rdcronin authored and Commit bot committed Sep 26, 2014
1 parent f6506c3 commit e458b10
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions chrome/browser/ui/views/toolbar/browser_action_view.cc
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ void BrowserActionView::UpdateState() {
SetTooltipText(name);
SetAccessibleName(name);

Layout(); // We need to layout since we may have added an icon as a result.
SchedulePaint();
}

Expand Down

0 comments on commit e458b10

Please sign in to comment.