Add \r back for the KeyEvent::Enter #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Vojta <[email protected]>
Signed-off-by: Robert Vojta <[email protected]>
TimonPost
approved these changes
Sep 20, 2019
december1981
pushed a commit
to december1981/crossterm
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, that's my mistake. When I said that the
\ris useless on Unix, I was right & wrong. In raw mode, the Enter key sends CR and the terminal driver translates this to the new line. I've just tested this and without the\r, the input event is CTRL-M, which is Enter. When added back, it's correctly translated to theKeyEvent::Enter. Sorry for introducing this bug.Introduce
KeyEvent::Tabmentioned in the #236.