Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyEvent::Tab not sent on windows #260

Closed
3kyro opened this issue Sep 28, 2019 · 2 comments
Closed

KeyEvent::Tab not sent on windows #260

3kyro opened this issue Sep 28, 2019 · 2 comments
Labels

Comments

@3kyro
Copy link

3kyro commented Sep 28, 2019

on window_input.rs, the check for KeyEvent::Tab is nested inside a key_state.has_state(SHIFT_PRESSED) check and is not correctly sent .

                } else if key_state.has_state(SHIFT_PRESSED) {
                    // Shift + key press, essentially the same as single key press
                    // Separating to be explicit about the Shift press.
                    if character == '\t' {
                        Some(KeyEvent::BackTab)
                    } else {
                        Some(KeyEvent::Tab)
                    }

Since there is a refactoring in progress for crossterm-input I leave it to be corrected there.

@TimonPost
Copy link
Member

Thanks, I can fix this in my PR for input

@TimonPost
Copy link
Member

Fixed crossterm-rs/crossterm-input#3

@TimonPost TimonPost added the bug label Sep 29, 2019
december1981 pushed a commit to december1981/crossterm that referenced this issue Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants