feat: support promises and error code #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bang9
commented
Oct 11, 2019
•
bang9
commented
- feat: support promises
- feat: support error code partially (카카오 로그인 및 로그아웃에 관련된 오류를 RN으로 토스하지 않는것 같습니다. #46)
- doc: update readme
- update examples and types
|
@bang9 안녕하세요~ 번거로우시겠지만 |
@hyochan 안녕하세요!
|
hyochan
reviewed
Oct 12, 2019
|
다음부턴 rebase로 남의 커밋 빼고 그 위에 상태에서 본인 커밋만 들어가게 하여 상태관리를 더욱 용이하게 하면 좋을 것 같습니다 :) |
|
@heyman333 확인해주시고 머지 및 배포 부탁드립니다~ |
heyman333
reviewed
Oct 14, 2019
- feat: support promises - feat: support error code partially - doc: update readme - update examples and types merge migration - index.d.ts changing merged into index.ts - renaming podspec file react-native-kakao-logins to RNSKakaoLogin - added postinstall command to Examples for build typescript project(file:../)
(cherry picked from commit ee9340e)
(cherry picked from commit 85b65d4)
|
@bang9 고생하셨습니다 시간이 되는대로 확인하고 이상 없으면 머지 후 배포 하겠습니다~ |
heyman333
reviewed
Oct 18, 2019
heyman333
reviewed
Oct 20, 2019
There was a problem hiding this comment.
@bang9 동작은 정상적으로 동작하는것 확인했습니다 🎉
예제 프로젝트로 테스트중에 다음과 같은 문제가 있었는데 이점만 한번 더 확인해 주실 수 있을까요?
- Podfile.lock파일을 삭제후 다시 한번 설치 해주시기 바랍니다. (바로 pod install하니 충돌이 나네요)
- 괜찮으시다면
debug.keystore파일을/KakaoLoginExample/android/app에 추가 해주실 수 있을까요? 테스트시 디버그 키스토어를 못찾아서 따로 생성해줘야하고 카카오 홈페이지가서 프로젝트 셋팅 까지 해야하는 불편함이 있네요 ㅠㅠ (.gitignore에서 해당파일만 제거)
heyman333
reviewed
Oct 21, 2019
android/src/main/java/com/dooboolab/kakaologins/RNKakaoLoginsModule.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/dooboolab/kakaologins/RNKakaoLoginsModule.java
Outdated
Show resolved
Hide resolved
|
@heyman333 고생많으셨습니다~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.