-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Concepts root page #666
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good @plumbis, I tested all the links too. Just a few nits for you to consider and decide if/how you'd like to incorporate ✅
content/v1.14/concepts/_index.md
Outdated
[composition documentation]: {{<ref "./compositions" >}} | ||
Crossplane extends Kubernetes allowing Kubernetes to create and manage | ||
resources external to Kubernetes. Crossplane enables platform engineers to | ||
create custom APIs and abstractions combining both native Kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've felt like a lot of folks don't get what the point of custom APIs/abstractions if you don't make it clear, e.g. so their developers can get self-service provisioning of the infra they need. Is there a way to work that in?
custom API Crossplane creates a single Composite Resource and links all | ||
the related managed resources to it. | ||
|
||
* [**Claims**]({{<ref "./claims">}}) are like Composite Resources, but exist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mention that the point of this is for developer/team access?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
content/v1.14/concepts/_index.md
Outdated
Composite Resource. | ||
|
||
* [**Patches and Transforms**]({{<ref "./patch-and-transform">}}) allow platform | ||
engineers to change user inputs to their custom API and affect how Crossplane |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of change
, would accept
work better here?
@plumbis do we want to get this in for 1.15? |
Signed-off-by: Pete Lumbis <[email protected]>
377e280
to
1c27e86
Compare
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Added in JBW's feedback and copied the updated content to v1.15 |
This rewrites the /concepts root page to add new top-level components (Composition functions, Usages) and to pass vale.
This update also slims down the descriptions of each component to not create too much duplication for what's detailed inside each individual component.
Resolves #617 (Boston represent)