-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to watch referenced or managed Kubernetes resources #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Fixes crossplane-contrib#138 Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
turkenh
commented
May 3, 2024
turkenh
commented
May 3, 2024
sttts
reviewed
May 3, 2024
sttts
reviewed
May 3, 2024
Signed-off-by: Hasan Turken <[email protected]>
Merged
6 tasks
sttts
reviewed
May 8, 2024
sttts
reviewed
May 8, 2024
sttts
reviewed
May 8, 2024
sttts
reviewed
May 8, 2024
sttts
reviewed
May 8, 2024
sttts
reviewed
May 8, 2024
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
sttts
reviewed
May 10, 2024
sttts
reviewed
May 10, 2024
sttts
reviewed
May 10, 2024
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
From e2e test logs:
|
sttts
reviewed
May 10, 2024
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a little distorted:
// Copyright 2024 The Crossplane Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, we really have that format in Crossplane?
Lgtm |
sttts
approved these changes
May 10, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR introduces the capability of watching referenced or managed Kubernetes resources as an "alpha feature".
When provider started with
--enable-watches
argument, it will be possible to configure an Object to watch relevant resources by settingspec.watch: true
which is off by default.The implementation is heavily based on the realtime compositions in Crossplane (as suggested by @sttts), however, we still have a good amount of divergence due to the difference between use cases.
Fixes #159
Fixes #212
Fixes #164
Fixes #138
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Touch (e.g. add a random label) referenced configmap (bar) and check for the log line with message "Enqueueing Object because referenced resource changed"
Touch (e.g. add a random label) managed configmap (foo) and check for the log line with message "Enqueueing Object because referenced resource changed"