This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Use IdentifierFromProvider for bucket as a workaround for #12 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…contrib#12 Signed-off-by: Hasan Turken <[email protected]>
Closed
|
Closing this as we chose another solution to move forwards: #12 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Due to this terraform gcp provider issue, our first refresh hangs (for a timeout of 20m) with retries if we have an "id" set for a non-existing bucket.
This PR aims to work around this issue by using
IdentifierFromProviderexternal name config which means not settingidin the first refresh at all.Fixes #12
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Create/delete a bucket using the example manifest under
examplesdir.