Key alias fix #950
Merged
Key alias fix #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… empty spec which makes the for loops in conversion functions throw compile errors since there is nothing to process and variables end up unused Signed-off-by: Muvaffak Onus <[email protected]>
…e otherwise it will not go away for days. Signed-off-by: Muvaffak Onus <[email protected]>
|
Opened aws-controllers-k8s/community#1069 to address ignoring all fields in |
muvaf
force-pushed
the
key-alias-fix
branch
2 times, most recently
from
b668cd9 to
1231a51
Compare
9 tasks
negz
approved these changes
Nov 17, 2021
| @@ -14,8 +14,6 @@ See the License for the specific language governing permissions and | |||
| limitations under the License. | |||
| */ | |||
|
|
|||
| // Code generated by ack-generate. DO NOT EDIT. | |||
|
|
|||
There was a problem hiding this comment.
Could be worth a note somewhere to explain why this resource looks like generated code, but "isn't".
There was a problem hiding this comment.
Added a comment to all those files pointing to description of this PR for details.
Signed-off-by: Muvaffak Onus <[email protected]>
|
Successfully created backport PR #951 for |
tektondeploy
pushed a commit
to gtn3010/provider-aws
that referenced
this pull request
Mar 12, 2024
…-and-arn-to-docdb-secret added endpoint and arn to docdb cluster secret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I merged #779 along with a few other PRs but apparently it broke
lintaction because of usage of a deprecated function from crossplane-runtime. Since we don't require PRs to be up-to-date, it slipped through the cracks.When I tried to fix it, I realized that we can actually use external name annotation feature instead of
spec.aliasName. But if we remove that field from spec, then we'd have all fields inignore(total of two fields) and this causes generatedforloops to be empty, hence code won't compile since the secondary value in for loop, i.e._, elem := ...is unused. It's a bug in the code generator we need to fix and there isn't much workaround. IncludingTargetKeyIdfield didn't help since we have to ignore it because it's marked as required otherwise but we use ref & selector for that field. So, I ended up removing this from code-gen for now until the issue is fixed.One additional thing I had to do was to assume that if
Keyis inPendingDeletionstate, then we should treat it as deleted, otherwise it'll be stuck for days.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually together with
KMS Key.