Rename ElasticIP to Address and bump to v1beta1 #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chris <[email protected]>
hasheddan
reviewed
Mar 15, 2021
apis/ec2/v1beta1/referencers.go
Outdated
| @@ -209,19 +207,19 @@ func (mg *NATGateway) ResolveReferences(ctx context.Context, c client.Reader) er | |||
| mg.Spec.ForProvider.SubnetID = aws.String(subnetIDResponse.ResolvedValue) | |||
| mg.Spec.ForProvider.SubnetIDRef = subnetIDResponse.ResolvedReference | |||
|
|
|||
| // // Resolve spec.elasticIp | |||
| AllocationIDRespone, err := r.Resolve(ctx, reference.ResolutionRequest{ | |||
| /*// // Resolve spec.elasticIp | |||
There was a problem hiding this comment.
Is this intentionally commented out?
There was a problem hiding this comment.
sigh. had to comment it out to get generate going. am fixing
Signed-off-by: chris <[email protected]>
Signed-off-by: chris <[email protected]>
|
@hasheddan when ya get a chance anything else needed on this one? |
hasheddan
approved these changes
Apr 1, 2021
tektondeploy
pushed a commit
to gtn3010/provider-aws
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chris [email protected]
Description of your changes
Rename ElasticIP to Address and bump to v1beta1
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Ran unit tests. Created example using locally run