Update CODE_GENERATION.md #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasheddan
reviewed
Mar 11, 2021
There was a problem hiding this comment.
@dickiesanders thanks! Looks like your commit is missing sign off, would you mind adding that?
The "Register CRD" link was incorrectly pointing to the apigateway setup.go file. Updated to the correct apis/aws.go file location. Signed-off-by: Richard Sanders <[email protected]>
dickiesanders
force-pushed
the
updated-incorrect-register-crd-link
branch
from
1c32fd8 to
324da56
Compare
|
@hasheddan - Ty and signoff complete! |
hasheddan
approved these changes
Mar 11, 2021
tektondeploy
pushed a commit
to gtn3010/provider-aws
that referenced
this pull request
Mar 12, 2024
Remove old workflows and reuse new ones: Backport, Comment Commands and Tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The "Register CRD" link was incorrectly pointing to the apigateway setup.go file. Updated to the correct apis/aws.go file location.
Fixes # - Incorrect "Register CRD" link found in the CODE_GENERATION.md file.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested updated link in GitHub branch.
No provider code updates.