fix(lambda): Policy parsing for permissions when using roles as principles #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterMX
changed the title
|
Needs rebase on #2154 Also, please adjust PR title to follow CC conventions |
kkendzia
force-pushed
the
fix/lambda_permission_policy_parsing
branch
from
e80be49 to
483a4df
Compare
…es as principles Signed-off-by: Kevin Kendzia <[email protected]>
kkendzia
force-pushed
the
fix/lambda_permission_policy_parsing
branch
from
483a4df to
d1aab6b
Compare
|
Successfully created backport PR #2160 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
When using roles as principle in permissions.lambda the key is "AWS", which got lost when unmarshaling the returned policy.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Ran provider locally against AWS and added unittest