feat: implement isUpToDate for transfer server #2151
+338
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Kendzia <[email protected]>
kkendzia
force-pushed
the
feat/transfer_server_isuptodate
branch
from
63926df to
4f34868
Compare
anagarlau
reviewed
Jan 28, 2025
|
|
||
| } | ||
|
|
||
| func isNotUpToDate(in svcapitypes.ServerParameters, out *svcsdk.DescribedServer) bool { //nolint:gocyclo |
There was a problem hiding this comment.
HostKey might be missing
There was a problem hiding this comment.
HostKey isn't available in DescribedServer, only its fingerprint.
There was a problem hiding this comment.
should be covered by ResourceLateInitialized then :)
anagarlau
reviewed
Jan 28, 2025
| } | ||
|
|
||
| if !cmp.Equal(in.Domain, out.Domain) { | ||
| return true |
There was a problem hiding this comment.
Domain can't be changed so it shouldn t trigger an update call. Usually the field is ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Implementation of isUpToDate function for Transfer Server.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Locally ran provider for verification and unit test