Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(efs): Add poll-interval to EFS mount target #2015

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

lbowe
Copy link
Contributor

@lbowe lbowe commented Mar 19, 2024

Description of your changes

Adds WithPollInterval to efs.MountTarget so that the requeue-after time uses the --poll argument override.

Fixes #2014

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

minor change, passed all existing tests.

Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @lbowe could you sign your commits?

@lbowe lbowe force-pushed the master branch 2 times, most recently from 2c50b25 to e020e39 Compare March 20, 2024 14:07
@lbowe
Copy link
Contributor Author

lbowe commented Mar 20, 2024

@MisterMX Apologies for missing that, it is now signed.

@MisterMX MisterMX merged commit 120c284 into crossplane-contrib:master Mar 20, 2024
9 checks passed
Copy link

Successfully created backport PR #2017 for release-0.47.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set poll-interval time for EFS mount target beyond default
2 participants