Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(glue/crawler): lateinit lakeFormationConfiguration #1967

Merged

Conversation

wotolom
Copy link
Contributor

@wotolom wotolom commented Dec 6, 2023

Description of your changes

With the aws sdk bump from #1523 glue.Crawler got a new parameter/field lakeFormationConfiguration, which needs to be lateinit to avoid an update-loop.

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

manually

Signed-off-by: Charel Baum (external expert on behalf of DB Netz AG) <[email protected]>
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @wotolom!

@MisterMX MisterMX merged commit 58a9f38 into crossplane-contrib:master Dec 11, 2023
@wotolom wotolom deleted the glue-crawler-lateinit-new-field branch December 11, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants