Skip error if role no longer exists in instance profile deletion #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing the PreDelete step on an `InstanceProfile` that detaches a role via `RemoveRoleFromInstanceProfileWithContext` it is possible that the role no longer exists. If so, the `InstanceProfile` can no longer be deleted succesfully, repeatedly failing the `PreDelete` step. This ignores the error is `NoSuchEntity` is returned when detaching the role as the role not existing implies we should be able to proceed with the delete step for the instancep profile. Signed-off-by: justin.miron <[email protected]>
justinmir
force-pushed
the
fix-instance-profile-deletion
branch
from
a8b9df2 to
9b616a1
Compare
haarchri
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
When performing the PreDelete step on an
InstanceProfilethat detaches a role viaRemoveRoleFromInstanceProfileWithContextit is possible that the role no longer exists. If so, theInstanceProfilecan no longer be deleted succesfully, repeatedly failing thePreDeletestep.This ignores the error is
NoSuchEntityis returned when detaching the role as the role not existing implies we should be able to proceed with the delete step for the instance profile.Fixes #1713
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Use of fork in internal crossplane deployment, instance profiles no longer get stuck during teardown due to the role already being detached and deleted.