feat(aws): bump aws-sdk-go to v1.44.174 #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for driving this - overall looks good |
|
@haarchri Sure, let me know when it's merged and I'll rebase |
|
done! @AlexLast can you rebase ? thanks ;) |
Signed-off-by: Alex Last <[email protected]>
|
@haarchri Have rebased and re run Looks like there are a couple of resources reported by |
|
thats what i wanted to see ;) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
We need to make use of a new RDS
DBInstanceparameter that is in a later version of the AWS SDK, specifically being able to setCACertificateIdentifier. This pull request bumpsaws-sdk-goto versionv1.44.174, the version where this parameter was introduced.I've added all new resources to
ignore.resource_namesso they can be introduced more carefully, however let me know if this isn't the correct approach.Also needed to slightly refactor how tagging works in
cloudwatchlogs/loggroup/setup.goto work around some deprecation warnings.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Yet to do any testing, however I'll be running a build locally to test out some resources and ensure things are working as expected.S3.Bucket,S3.BucketPolicy,IAM.Role,IAM.Policy,IAM.RolePolicyAttachment,EC2.SecurityGroup,EC2.SecurityGroupRule,RDS.DBSubnetGroup,RDS.DBCluster,RDS.DBClusterParameterGroup,RDS.DBInstance,Kinesis.Stream,DynamoDB.Table,KMS.Key.CloudwatchLogs.LogGroupis working as expected.