Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cache): fix version handling for #1617 #1619

Merged

Conversation

haarchri
Copy link
Member

Signed-off-by: Christopher Paul Haar [email protected]

Description of your changes

changed version handling for cache cluster

Fixes #1617

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

added new example

kubectl get managed
NAME                                                          STATUS      READY   SYNCED   AGE
cachecluster.cache.aws.crossplane.io/aws-memcached-standard   available   True    True     19m
cachecluster.cache.aws.crossplane.io/redis-cache-cluster      available   True    True     19m

Copy link
Contributor

@ezgidemirel ezgidemirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @haarchri! LGTM

@haarchri haarchri requested a review from MisterMX March 5, 2023 17:04
@MisterMX MisterMX merged commit d5f422e into crossplane-contrib:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elasticache cluster: Specific version selection is not allowed for 'x.x.x', please use 'x.x'
4 participants