Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rds): DBCluster controller not recognizing changes in VpcSecurityGroups #1580

Conversation

schroeder-paul
Copy link
Contributor

Description of your changes

The controller does not pick up the following difference and rectifies ist:

apiVersion: rds.aws.crossplane.io/v1alpha1
kind: DBCluster
metadata:
  ...
spec:
  forProvider:
    ...
    vpcSecurityGroupIDs:
      - sg-0ea3574b267cb293c                <=== does not match the one from below
...
status:
  atProvider:
    ...
    vpcSecurityGroups:
      - status: active
        vpcSecurityGroupID: sg-563ab33d     <=== dose not match the one from above
  conditions:
    - lastTransitionTime: "2022-11-17T16:53:44Z"
      reason: Available
      status: "True"
      type: Ready
    - lastTransitionTime: "2022-11-17T16:51:42Z"
      reason: ReconcileSuccess
      status: "True"
      type: Synced

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

See added tests.

@schroeder-paul schroeder-paul force-pushed the consider-vpc-sg-in-DBCluster-diff branch from bfd0c75 to 989cc2d Compare November 18, 2022 13:05
@schroeder-paul schroeder-paul force-pushed the consider-vpc-sg-in-DBCluster-diff branch from 989cc2d to 8466fae Compare November 18, 2022 14:00
@schroeder-paul schroeder-paul marked this pull request as ready for review November 18, 2022 14:08
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix @schroeder-paul!

@MisterMX MisterMX merged commit fde8c4d into crossplane-contrib:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants