Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(batch): CE update handling #1567

Merged
merged 1 commit into from
Nov 12, 2022
Merged

fix(batch): CE update handling #1567

merged 1 commit into from
Nov 12, 2022

Conversation

wotolom
Copy link
Contributor

@wotolom wotolom commented Nov 11, 2022

Description of your changes

Follow-up PR for this quick fix

  • handling of ComputeResources and other new updatable fields
  • fix misuse of lateInitialize in isUpToDate

Latest SDK bump made more children of the field ComputeResources ComputeEnvironment of type EC2 or SPOT updatable, but only for specific AllocationStrategy value.

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

manually tested with the examples

fix(batch): CE update handling
dbf039a 
Signed-off-by: Charel Baum <[email protected]>
haarchri
haarchri approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for recap this

@haarchri haarchri merged commit d489335 into crossplane-contrib:master Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haarchri haarchri haarchri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wotolom @haarchri