Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replication group fixes: multiAz and Tag update support #1277

Merged

Conversation

stevendborrelli
Copy link
Contributor

@stevendborrelli stevendborrelli commented Apr 28, 2022

Description of your changes

This PR adds functionality to update multiAZ and tags for ElastiCache Replication groups.

Fixes #914

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • Created a replication group and changed Tags and MultiAZenabled.
apiVersion: cache.aws.crossplane.io/v1beta1
kind: ReplicationGroup
metadata:
  name: redis-replication-group
spec:
  forProvider:
    region: us-east-1
    replicationGroupDescription: "A redis replication group"
    applyModificationsImmediately: true
    engine: "redis"
    engineVersion: "5.0.6"
    port: 6379
    cacheSubnetGroupName: borrelli-cache-test
    #cacheSubnetGroupName: default
    numCacheClusters: 2
    cacheParameterGroupName: default.redis5.0
    cacheNodeType: cache.t3.medium
    securityGroupIds:
      - sg-xxxxxyyyyy 
    automaticFailoverEnabled: true
    multiAZEnabled: false
    tags:
      - key: Name
        value: redis-replication-group
      #- key: VS
      #  value: sandbox
      - key: Environment
        value: dev
      - key: Squad
        value: my-team
      - key: Tier
        value: sandbox

Signed-off-by: Steven Borrelli <[email protected]>
Signed-off-by: Steven Borrelli <[email protected]>
Signed-off-by: Steven Borrelli <[email protected]>
Signed-off-by: Steven Borrelli <[email protected]>
Signed-off-by: Steven Borrelli <[email protected]>
Signed-off-by: Steven Borrelli <[email protected]>
Signed-off-by: Steven Borrelli <[email protected]>
Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for Implementation - tested and it is working

@haarchri haarchri merged commit 394abc7 into crossplane-contrib:master May 6, 2022
@stevendborrelli stevendborrelli deleted the replication-group-fixes branch May 6, 2022 13:36
febarbosa182 pushed a commit to febarbosa182/provider-aws that referenced this pull request May 23, 2022
…ontrib#1277)

* initial multi-az support

Signed-off-by: Steven Borrelli <[email protected]>
Signed-off-by: Felipe Barbosa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replication group MultiAZ
2 participants