Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI to work with Crossplane v1.7.0 #1239

Merged
merged 4 commits into from
Mar 30, 2022
Merged

Update CI to work with Crossplane v1.7.0 #1239

merged 4 commits into from
Mar 30, 2022

Conversation

hasheddan
Copy link
Member

Description of your changes

Updates CI to extract package contents into a gzipped file compatible with Crossplane's package cache format.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

make build and make e2e and verified success

>>>>>>> --- INTEGRATION TESTS ---

>>>>>>> installing provider-aws into "crossplane-system" namespace
provider.pkg.crossplane.io/provider-aws created

>>>>>>> check kind node cache dir contents
total 408
drwxrwxr-x 2 1000 1000   4096 Mar 30 02:48 .
drwxr-xr-x 1 root root   4096 Mar 30 02:48 ..
-rw-r--r-- 1 1000 1000 406797 Mar 30 02:47 provider-aws.gz

>>>>>>> waiting for provider to be installed
provider.pkg.crossplane.io/provider-aws condition met

>>>>>>> uninstalling provider-aws
provider.pkg.crossplane.io "provider-aws" deleted
waiting for provider to be deleted for another 3 seconds
waiting for provider to be deleted for another 3 seconds

Integration tests succeeded!

>>>>>>> Cleaning up...
Deleting cluster "build-b3b12a66-inttests" ...
22:49:13 [ OK ] integration tests passed

@hasheddan
Update build subdmodule to consume up tooling
1a3daeb 
Updates build submodule to consume up tooling, which provides the
ability to extract package contents into a Crossplane cache compatible
format.

Signed-off-by: hasheddan <[email protected]>
@hasheddan
Update integration tests with up xpkg xp-extract
c1e7a3f 
Updates integration tests with up xpkg xp-extract to allow for
extracting package contents from and image into a Crossplane cache
compatible format.

Signed-off-by: hasheddan <[email protected]>
@hasheddan
Add up dependency to test-integration target
3336ea2 
Adds up as a dependency to integration test target so it can be used in
script.

Signed-off-by: hasheddan <[email protected]>
@hasheddan
Drop docker cp command used to appease
69a0766 
Drops unneeded docker cp command that was required in Jenkins because
host dir cache was not mounted correctly.

Signed-off-by: hasheddan <[email protected]>
@hasheddan hasheddan requested review from haarchri and muvaf and removed request for haarchri March 30, 2022 13:34
@hasheddan hasheddan mentioned this pull request Mar 30, 2022
Closed
haarchri
haarchri approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hasheddan thanks

@hasheddan hasheddan merged commit ef937a6 into crossplane-contrib:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haarchri haarchri haarchri approved these changes

@muvaf muvaf Awaiting requested review from muvaf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hasheddan @haarchri