Cognito/resource server #1217
Merged
Cognito/resource server #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febarbosa182
force-pushed
the
cognito/resource-server
branch
from
c198d7e to
c9400b5
Compare
|
@febarbosa182 thanks for contributing did you checked ? https://github.com/crossplane/provider-aws/blob/master/CODE_GENERATION.md#mandatory-custom-parts |
|
@febarbosa182 thanks for updating - can you Check your DCO Signing for the latest commit ? |
febarbosa182
force-pushed
the
cognito/resource-server
branch
from
101ba92 to
23f2eaf
Compare
febarbosa182
force-pushed
the
cognito/resource-server
branch
from
14107c6 to
a1d4dff
Compare
|
@febarbosa182 thanks for adding example can you use rebase instead of merge ? Keeps the History clean |
Signed-off-by: Felipe Barbosa <[email protected]>
Signed-off-by: Felipe Barbosa <[email protected]>
Signed-off-by: Felipe Barbosa <[email protected]>
febarbosa182
force-pushed
the
cognito/resource-server
branch
from
a1d4dff to
ae763db
Compare
|
Thanks @haarchri for all your support in this issue and sorry for late update |
haarchri
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds support for resource server on AWS Cognito to allow client credentials flow.
This functionality is mentioned in #1216
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
This code has been tested manually tested against AWS using Kind running provider-aws locally out-of-cluster.