New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add default Crossplane tags to iam.Policy #1207

Merged

haarchri merged 1 commit into crossplane-contrib:master from cebernardi:add-default-tags-to-iam-policy

Mar 18, 2022

Contributor

cebernardi commented Mar 14, 2022 •

edited

Loading

Signed-off-by: Cecilia Bernardi [email protected]

Description of your changes

Fixes #1206

I have:

Read and followed Crossplane's contribution process.
Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Unit Tests
Manual tests on a kind cluster configured with an AWS account:
- Create resource scenario: a new iam.policy crossplane resource was created and the default tags were added in the kubernetes cluster; the policy was successfully created in the configured AWS account with the default tags
- Add custom tags scenario: custom tags were added to the crossplane resources, and the AWS policy was successfully tagged with the new tags
- Modify custom tags scenario: custom tags were modified on the kubernetes resource, and the modification was successfully reconciled with the AWS resource (could observe tags values being modified)
- Remove custom tags scenario: custom tags were removed from the kubernetes resource, and after the reconciliation, the tags were removed also from the AWS resource
- Modify / Remove default tags: default tags were removed and changed, and they were immediately restored. No modification was observed on the AWS resource

cebernardi changed the title ~~added default Crossplane tags to iam.Policy~~ add default Crossplane tags to iam.Policy

cebernardi force-pushed the add-default-tags-to-iam-policy branch from 4834bb0 to dc91682 Compare

March 14, 2022 12:22

Member

haarchri commented Mar 14, 2022

@cebernardi can you please rebase ? we had an issue in master branch


          added default Crossplane tags to iam.Policy

Signed-off-by: Cecilia Bernardi <[email protected]>

cebernardi force-pushed the add-default-tags-to-iam-policy branch from dc91682 to 3324643 Compare

March 14, 2022 18:43

Contributor Author

cebernardi commented Mar 15, 2022

@cebernardi can you please rebase ? we had an issue in master branch

sure, done!

haarchri approved these changes

View reviewed changes

Member

haarchri left a comment

LGTM - tested thanks for contribution

haarchri merged commit a32b7d3 into crossplane-contrib:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet