Add AccessPoint resource for EFS

[EdgeJ]

Signed-off-by: EdgeJ [email protected]

Description of your changes

Adds the AccessPoint resource for the EFS family by removing the ignore parameters in the code generation config and auto-generating the main controller code.

Fixes #1182

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Example yaml configuration added to the repo. Creation and deletion have been tested by manually applying to a local k8s cluster and verifying created infrastructure.

[zonybob]

@EdgeJ thanks again for this PR! Looking forward to having AccessPoints soon.

I checked out your branch, built and pushed to my cluster. The initial attempt to create an AccessPoint was successful in the sense that the AWS resource was indeed created and becomes available, however the AccessPoint managed resource itself never becomes Ready: true ... it is stuck at Ready: false for Reason: Creating

UPDATE:
(I admittedly have not done a new resource type before, so I am learning)
It looks like we're just missing a postObserve
https://github.com/Simspace/provider-aws/blob/edgej/efs-access-point-resource/CODE_GENERATION.md#readiness-check

After adding that, it seems better (although I am not certain if what I did was the "most correct" for Access Points.)

func postObserve(_ context.Context, cr *svcapitypes.AccessPoint, resp *svcsdk.DescribeAccessPointsOutput, obs managed.ExternalObservation, err error) (managed.ExternalObservation, error) {
	if err != nil {
		return managed.ExternalObservation{}, err
	}
	switch aws.StringValue(resp.AccessPoints[0].LifeCycleState) {
	case string(svcapitypes.LifeCycleState_available):
		cr.SetConditions(xpv1.Available())
	case string(svcapitypes.LifeCycleState_creating):
		cr.SetConditions(xpv1.Creating())
	case string(svcapitypes.LifeCycleState_deleting):
		cr.SetConditions(xpv1.Deleting())
	case string(svcapitypes.LifeCycleState_error):
		cr.SetConditions(xpv1.Unavailable())
	case string(svcapitypes.LifeCycleState_deleted):
		cr.SetConditions(xpv1.Unavailable())
	}

	return obs, nil
}

[EdgeJ]

I checked out your branch, built and pushed to my cluster. The initial attempt to create an AccessPoint was successful in the sense that the AWS resource was indeed created and becomes available, however the AccessPoint managed resource itself never becomes Ready: true ... it is stuck at Ready: false for Reason: Creating

UPDATE: (I admittedly have not done a new resource type before, so I am learning) It looks like we're just missing a postObserve https://github.com/Simspace/provider-aws/blob/edgej/efs-access-point-resource/CODE_GENERATION.md#readiness-check

After adding that, it seems better (although I am not certain if what I did was the "most correct" for Access Points.)

Thanks @zonybob! I hadn't caught that it wasn't becoming ready. I was working from memory on how to set up the auto-generated resources and forgot about setting up readiness. I'll add the readiness check today and push the changes up.

[zonybob]

Just checking on status of this pull request. Need any more testing or anything? Do we have a target release in mind? Thanks!

[haarchri]

tested the AccessPoint working as expected - thanks for implementation - LGTM