fix(s3): Extract QueueARN instead of external name #1161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This changes the referencer implementation for
spec.forProvider.noficationConfiguration.queueConfigurations[].queueArn
forBucket
so it will extract the ARN from theQueue
resource instead of the default external name annotation.Fixes #1160
It will also make the field optional, because it can be filled using referencers.
Additionally, I updated the put bucket notification configuration error message to give a
hint about missing IAM credentials. (Because the AWS error message is incomplete and might be misleading).
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Manually using the following YAML: