-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(InstanceProfile): Add IAM InstanceProfile Managed Resource #1159
feat(InstanceProfile): Add IAM InstanceProfile Managed Resource #1159
Conversation
240cc0d
to
a048ea3
Compare
@ytsarev can you rebase ? ;) sdk bump is done |
Regenerate without Region Commit iam generator-config make generate result Setup Controller and Register CRD Fix imports and compile Regenerate not requiring InstanceProfileName within the spec Fix externalname and readiness, provide example Generate rolereference Fix field capitalization Hook into postCreate to call AddRoleToInstanceProfile Handle deletion and update examples Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
a048ea3
to
f5e5a2a
Compare
@haarchri that's amazing, thanks! PR is rebased :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a few code comments - think its better to use svcsdkapi.IAMAPI
like in other provider-aws resource implementations and call add/removeRoleFromInstanceProfileWithContext
what do you think @ytsarev
in general the creation / deletion is working =)
Co-authored-by: Christopher Haar <[email protected]> Signed-off-by: Yury Tsarev <[email protected]>
2c8ecb8
to
24c367e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @ytsarev
Signed-off-by: Yury Tsarev <[email protected]>
fix(InstanceProfile): follow up fix of #1159
…ane-runtime Bump crossplane-runtime to commit 7fcb8c5cad6f
Description of your changes
This PR adds support for IAM InstanceProfile including the IAM role association.
Caveats:
preCreate
hookpreDelete
hookFixes #1064
Depends on #1122 to be merged first.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
e2e: