Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ec2-instance): changed SpotMarketOptions for Spot Instances #1083

Merged
merged 1 commit into from
Jan 29, 2022
Merged

fix(ec2-instance): changed SpotMarketOptions for Spot Instances #1083

merged 1 commit into from
Jan 29, 2022
+34 −7

Conversation

haarchri
Copy link
Member

Signed-off-by: haarchri [email protected]

Description of your changes

changed SpotMarketOptions to fits API - and added example

Fixes #1079

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

k get instances
NAME                   READY   SYNCED   ID                    STATE     AGE
sample-instance        True    True     i-08e2b57a6c7873a1e   running   5m35s
sample-instance-spot   True    True     i-00001a3bbbb156e28   running   10m

@haarchri haarchri mentioned this pull request Jan 23, 2022
Closed
@haarchri haarchri merged commit e897d6b into crossplane-contrib:master Jan 29, 2022
@haarchri haarchri deleted the fix/ec2-instance-types branch January 29, 2022 12:57
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
@ytsarev
Merge pull request crossplane-contrib#1083 from ytsarev/rds-add-selec…
b4bbf97 
…tors

[rds]: Add `dbParameterGroupNameSelector` to `ClusterInstance`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muvaf muvaf muvaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ec2-instance] conflicting yaml requirements
2 participants
@haarchri @muvaf