Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(name): fix transfer/user &cr.name and use annotation #1053

Merged

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Jan 5, 2022

Signed-off-by: haarchri [email protected]

Description of your changes

fixed: never use cr.Name, the source of truth is always the annotation for transfer/user

Fixes #1051

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

apiVersion: transfer.aws.crossplane.io/v1alpha1
kind: User
metadata:
  annotations:
    crossplane.io/external-name: testwithannotation
  name: test
spec:
  forProvider:
    region: us-east-1
    homeDirectory: /crossplane-example-bucket/example
    homeDirectoryType: PATH
    roleRef:
      name: somerole
    serverIDRef:
      name: example
    sshPublicKeyBody: "ssh-rsa xxx"
    tags:
      - key: myKey
        value: myValue
  providerConfigRef:
    name: example

image

Signed-off-by: haarchri <[email protected]>
@haarchri haarchri merged commit 9531351 into crossplane-contrib:master Jan 5, 2022
@haarchri haarchri deleted the fix/transfer-user-external-name branch January 5, 2022 20:51
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
…rnetes-patches

Update k8s.io/utils digest to e7106e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjustable username for transfer users
2 participants