Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ec2): vpcpeeringconnection fixed fields for resolvers, change tagger #1035

Merged

Conversation

haarchri
Copy link
Member

Signed-off-by: haarchri [email protected]

Description of your changes

  • Changed code-generator config yaml to correctly exclude VpcId and PeerVpcId
  • added VpcId and PeerVpcId to preCreate
  • removed old implementation for TagSpecification
  • added generic tagger, as tagger we use in other ec2 resources

Fixes #1033
Replace for #1034

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

NAME                                                 READY   SYNCED   EXTERNAL-NAME
vpcpeeringconnection.ec2.aws.crossplane.io/example   True    True     pcx-033c398f6652f347c

image

@linuxbsdfreak
Copy link

@haarchri When will this be mergred ? I have a composition that i need it for testing.

@haarchri haarchri requested a review from chlunde February 8, 2022 07:59
@chlunde
Copy link
Collaborator

chlunde commented Feb 8, 2022

@haarchri looks good to me, some conflicts needs to be resolved

@haarchri haarchri force-pushed the fix-vpcpeeringconnection branch from 317c74c to f86d392 Compare February 8, 2022 17:24
@haarchri haarchri force-pushed the fix-vpcpeeringconnection branch from f86d392 to 053b2d0 Compare February 8, 2022 17:26
@haarchri haarchri merged commit 5a112fc into crossplane-contrib:master Feb 8, 2022
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolvers and References not working in EC2 VPCPeering connection
3 participants