chore: dynamically generate GENERATED_SERVICES var #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The force push commit added a more secure regex for the excludes. |
muvaf
reviewed
Jan 8, 2022
muvaf
approved these changes
Feb 2, 2022
CODE_GENERATION.md
Outdated
Comment on lines
65
to
72
| If `apis/<serviceid>` is created from scratch, please add the new service name to the list called GENERATED_SERVICES in [Makefile](https://github.com/crossplane/provider-aws/blob/master/Makefile#L10). | ||
|
|
||
| ### Makefile | ||
|
|
||
| ```bash | ||
| - GENERATED_SERVICES="apigatewayv2" | ||
| + GENERATED_SERVICES="apigatewayv2,<serviceid>" | ||
| ``` | ||
| The serviceids are fetch from the paths of the generator-config.yaml automatically. | ||
|
|
||
| If this step fails for some reason, please raise an issue in [code-generator](https://github.com/aws-controllers-k8s/code-generator) | ||
| and mention that you're using Crossplane pipeline. |
There was a problem hiding this comment.
Let's remove the whole section as they don't need to know about this at all thanks to your discovery implementation.
Signed-off-by: Daniel Werdermann <[email protected]>
muvaf
approved these changes
Feb 2, 2022
tektondeploy
pushed a commit
to gtn3010/provider-aws
that referenced
this pull request
Mar 12, 2024
…eplication-configuration-key-ref feat(ref): add kms ref/selector in replication configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Werdermann [email protected]
Description of your changes
The variable in the Makefile is now generated from the paths of the generatec-config.yaml files. So no more editingof the Makefile and no merge conflicts.
Fixes #861
Fixes #862
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
make reviewableworks without changes.