Add default tags to iam.Role

[cebernardi]

Description of your changes

This PR adds the default Crossplane tags ("crossplane-kind", "crossplane-name", "crossplane-providerconfig") to IAMRoles

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

• Unit-tests
• Manual testing:
  • spin up a new kind cluster (kind create cluster --name crossplane-aws)
  • install CRDs (kubectl apply -f package/crds)
  • create resource scenario:
    • create an iam.Role in the cluster (kubectl apply -f examples/iam/role.yaml)
    • start crossplane-aws controller
    • verify that the tags "crossplane-kind", "crossplane-name", "crossplane-providerconfig" are added as expected
  • modify resource scenario:
    • delete tags from the resource: kubectl patch role.iam.aws.crossplane.io/somerole --type=json -p='[{"op": "remove", "path":"/spec/forProvider/tags"}]'
    • verify that the tags "crossplane-kind", "crossplane-name", "crossplane-providerconfig" are re-added as expected
  • start controller scenario:
    • stop provider-aws controller
    • reset the iam.Role (kubectl apply -f examples/iam/role.yaml)
    • start crossplane-aws controller
    • verify that the tags "crossplane-kind", "crossplane-name", "crossplane-providerconfig" are added as expected

[muvaf]

Thanks @cebernardi ! #996 moves IAMRole in identity group to iam group with kind name Role and I expect that PR to land in the next few days. Can we hold this one and rebase once that's merged?

[cebernardi]

yes sure!

[muvaf]

@cebernardi It's merged, we should be good to rebase this now!

[cebernardi]

nice, I'll rebase ASAP

[cebernardi]

@muvaf I rebased and squashed

[muvaf]

Thank you @cebernardi and congrats on the 1000th PR!! It should be good to merge after fixing those small import issues.

[muvaf]

@cebernardi we'll need you to sign DCO since it's your first contribution https://github.com/crossplane/provider-aws/pull/1000/checks?check_run_id=4535934088

[cebernardi]

I should have incorporated your suggestions, @muvaf

[haarchri]

LGTM - tested it - tagging is working - thanks ;)