Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Api Gateway Rest API #845

Closed
jbuettnerbild opened this issue Sep 28, 2021 · 7 comments
Closed

AWS Api Gateway Rest API #845

jbuettnerbild opened this issue Sep 28, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@jbuettnerbild
Copy link

At the moment only HTTP and WEBSOCKET are supported.

For my usecase i need a AWS REST Api Gateway.
Further: The Documentation of the Api Gateway is very bad (https://doc.crds.dev/github.com/crossplane/provider-aws/apigatewayv2.aws.crossplane.io/API/[email protected])
It will be very helpful to see the available options.
For example: for the required parameters protocolType something like Must be one of [HTTP, WEBSOCKET]

@jbuettnerbild jbuettnerbild added the enhancement New feature or request label Sep 28, 2021
@muvaf
Copy link
Member

muvaf commented Oct 6, 2021

@jbuettnerbild It seems these are the only types that are currently supported by AWS, see the AWS CLI command doc. It'd be more helpful if you can share commands, scripts or Terraform HCLs you use to achieve your goals so that we can see which resources and parameters are needed.

@jbuettnerbild
Copy link
Author

hi @muvaf.
in my case i use a REST Api Gateway to use a AWS Services (S3). I saw that this will also works with WEbSocket Api but i have no idee how to do that with crossplane. I saw the apigateway2 example: https://github.com/crossplane/provider-aws/blob/master/examples/apigatewayv2/integration.yaml
and maybe its just the integrationType but the documentation is very bad (empty): https://doc.crds.dev/github.com/crossplane/provider-aws/apigatewayv2.aws.crossplane.io/Integration/[email protected]#spec-forProvider-integrationType

Over the AWS Console you have four options.
Bildschirmfoto 2021-10-06 um 13 16 08

Currently i did this with terraform --> https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/api_gateway_rest_api
See the Note: Amazon API Gateway Version 1 resources are used for creating and deploying REST APIs

A better dokumentation or a example for AWS services over Websocket Api Gateway would be helpfull.

@apmartins85
Copy link

Hi folks .. We are actually facing the same issue! Is it this "issue" on crossplane roadmap?

@muvaf
Copy link
Member

muvaf commented Jan 20, 2022

It seems like we need support for apigateway API group. The current one is apigatewayv2 which doesn't include that. You can take a stab at it by following the code generation guide here or try jet-based AWS provider which has support for all types Terraform does.

@aleicher
Copy link

apigateway2 API group only supports the HTTP API Gateway. Our usecase would be to provision a private REST API Gateway in our VPC. REST API Gateway types are all part of the apigateway API group in AWS. So I guess following the code generation path mentioned by @muvaf would be the way to go, to add support for the apigateway group in provider-aws.

@aleicher
Copy link

maybe interesting for @apmartins85 and @jbuettnerbild check out the awesome provider-jet-aws (leveraging terraform under the hood).

It has coverage for both apigateway API versions, and from looking at the code in https://github.com/crossplane-contrib/provider-jet-aws it should provide support for the REST APIGateway in v0.4.0-preview according to https://doc.crds.dev/github.com/crossplane-contrib/provider-jet-aws/apigateway.aws.jet.crossplane.io/RestAPI/[email protected]

so if you need it earlier than it can be made into the provider-aws maybe you give the provider-jet-aws a spin. I guess I'll try it for my use case

@haarchri
Copy link
Member

implemented with #1230

tektondeploy pushed a commit to gtn3010/provider-aws that referenced this issue Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants