Can't delete ECR RepositoryPolicy for non-existent repository

[negz]

What happened?

I'm spinning up and down all of our examples in order to run some Crossplane conformance tests. My suspicion is that deleting the repository automatically deletes the policy, but Crossplane's logic for deleting the policy requires the repository to exist. Perhaps if we can't find the repository the policy should apply to when deleting we should just consider it gone? That would be around this area I think - https://github.com/crossplane/provider-aws/blob/84acbf60/pkg/controller/ecr/repositorypolicy/controller.go#L100

Disclaimer: I haven't dug deep here and am making some assumptions about how ECR repos and policies work.

How can we reproduce it?

I notice that I can kubectl apply -f examples/ecr at successfully, but I can't kubectl delete -f the same directory.

What environment did it happen in?

Crossplane version :1.2.2
provider-aws commit: 84acbf6

[negz]

CC @enderv, as I notice you built this managed resource out originally.

[enderv]

@negz took a quick poke think you are correct. I should have some time this week to try to get a fix up

[negz]

@enderv Thank you!