ResourceRecordSet Observe() fails when using dynamic endpoint configuration

[bobh66]

What happened?

The Observe function for ResourceRecordSets (or any Route53 resource) fails when the ProviderConfig is using dynamic endpoint configuration:

1.6596247083644836e+09  DEBUG   provider-aws    Cannot observe external resource        {
"controller": "managed/resourcerecordset.route53.aws.crossplane.io", 
"request": "/jowtest-26wj2-zlt8h", 
"uid": "5875de14-0b0c-4c21-a0b6-f3cda5cec400", 
"version": "728082259", 
"external-name": "jowtest-26wj2-zlt8h", 
"error": "failed to list the ResourceRecordSet resource: operation error Route 53: ListResourceRecordSets, failed to parse endpoint URL: parse \"https://route 53.us-east-1.amazonaws.com\": invalid character \" \" in host name",
"errorVerbose": "operation error Route 53: ListResourceRecordSets, failed to parse endpoint URL: parse \"https://route 53.us-east-1.amazonaws.com\": invalid character \" \" in host name
failed to list the ResourceRecordSet resource
github.com/crossplane-contrib/provider-aws/pkg/clients.Wrap
    /home/runner/work/provider-aws/provider-aws/pkg/clients/aws.go:1261
github.com/crossplane-contrib/provider-aws/pkg/controller/route53/resourcerecordset.(*external).Observe
    /home/runner/work/provider-aws/provider-aws/pkg/controller/route53/resourcerecordset/controller.go:107
github.com/crossplane/crossplane-runtime/pkg/reconciler/managed.(*Reconciler).Reconcile
    /home/runner/work/provider-aws/provider-aws/vendor/github.com/crossplane/crossplane-runtime/pkg/reconciler/managed/reconciler.go:767
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
    /home/runner/work/provider-aws/provider-aws/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:114
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
    /home/runner/work/provider-aws/provider-aws/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:311
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
    /home/runner/work/provider-aws/provider-aws/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
    /home/runner/work/provider-aws/provider-aws/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:227
runtime.goexit
    /opt/hostedtoolcache/go/1.17.11/x64/src/runtime/asm_amd64.s:1581"}

How can we reproduce it?

Use the following ProviderConfig:

---
apiVersion: aws.crossplane.io/v1beta1
kind: ProviderConfig
metadata:
 name: default
spec:
 credentials:
   source: InjectedIdentity
 endpoint:
   signingRegion: us-east-1
   url:
     dynamic:
       host: amazonaws.com
       protocol: https
     type: Dynamic

and deploy a ResourceRecordSet resource. When provider-aws tries to Observe the resource, the above error is caused because the Service ID for Route53 in the AWS SDK contains a space:

https://github.com/aws/aws-sdk-go-v2/blob/main/service/route53/api_client.go#L26

and the AWS client code is using the service as a part of the URL:

https://github.com/crossplane-contrib/provider-aws/blob/master/pkg/clients/aws.go#L195

Also Route53 is a "global" service like IAM so the region is not part of the URL and it needs to be handled the same way as IAM is handled today:

https://github.com/crossplane-contrib/provider-aws/blob/master/pkg/clients/aws.go#L193

I will push a PR.

What environment did it happen in?

Crossplane version: 1.9.0
AWS Provider 0.29.0