chore(ci): Use Go 1.23.5 to build images

Bump linter to v1.63.4. Keep go.mod at go 1.21 because it is not necessary to bump Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <[email protected]>
crossplane-contrib · Feb 3, 2025 · 933e483 · 933e483
1 parent bb6423b
commit 933e483
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 10 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -10,8 +10,8 @@ on:
 
 env:
   # Common versions
-  GO_VERSION: '1.21.2'
-  GOLANGCI_VERSION: 'v1.54.2'
+  GO_VERSION: '1.23.5'
+  GOLANGCI_VERSION: 'v1.63.4'
   DOCKER_BUILDX_VERSION: 'v0.14.1'
 
   # Common users. We can't run a step 'if secrets.AWS_USR != ""' but we can run

diff --git a/pkg/clients/ec2/securitygroup_diff.go b/pkg/clients/ec2/securitygroup_diff.go
@@ -46,7 +46,7 @@ func getKey(perm ec2types.IpPermission) ruleKey {
 	}
 }
 
-type ipPermissionMap struct {
+type ipPermissionMap struct { //nolint:recvcheck
 	FromPort   *int32
 	ToPort     *int32
 	IPProtocol *string
@@ -146,7 +146,7 @@ func (i ipPermissionMap) diffPrefixListIDs(other ipPermissionMap) []ec2types.Pre
 	return ret
 }
 
-func (i ipPermissionMap) diffUserIDGroupPair(other ipPermissionMap) []ec2types.UserIdGroupPair {
+func (i *ipPermissionMap) diffUserIDGroupPair(other ipPermissionMap) []ec2types.UserIdGroupPair {
 	var ret []ec2types.UserIdGroupPair
 	for key, r := range i.groups {
 		r2, ok := other.groups[key]

diff --git a/pkg/controller/mq/configuration/utils/xmlparse.go b/pkg/controller/mq/configuration/utils/xmlparse.go
@@ -8,7 +8,6 @@ import (
 	"github.com/google/go-cmp/cmp"
 )
 
-//nolint:musttag
 type Node struct {
 	XMLName xml.Name
 	Attr    []xml.Attr `xml:",any,attr"`
@@ -17,9 +16,8 @@ type Node struct {
 }
 
 func (n *Node) UnmarshalXML(d *xml.Decoder, start xml.StartElement) error {
-	//nolint:musttag
 	type node Node
-	return d.DecodeElement((*node)(n), &start)
+	return d.DecodeElement((*node)(n), &start) //nolint:musttag
 }
 
 func DiffXMLConfigs(c1, c2 string) (string, error) {

diff --git a/pkg/utils/pointer/pointer.go b/pkg/utils/pointer/pointer.go
@@ -64,7 +64,7 @@ func ToIntAsInt32(v int) *int32 {
 	if v == 0 {
 		return nil
 	}
-	val32 := int32(v)
+	val32 := int32(v) //nolint:gosec
 	return &val32
 }
 
@@ -73,7 +73,7 @@ func ToIntAsInt32Ptr(v *int) *int32 {
 	if v == nil {
 		return nil
 	}
-	val32 := int32(*v)
+	val32 := int32(*v) //nolint:gosec
 	return &val32
 }
 

diff --git a/pkg/utils/policy/types.go b/pkg/utils/policy/types.go
@@ -212,7 +212,7 @@ func (s *StringOrArray) UnmarshalJSON(data []byte) error {
 // StringOrSet is a string array that supports parsing from a single string
 // as a single entry array. Order of elements is not respected when comparing
 // two StringOrSet objects.
-type StringOrSet map[string]struct{}
+type StringOrSet map[string]struct{} //nolint:recvcheck
 
 func NewStringOrSet(values ...string) StringOrSet {
 	set := make(StringOrSet, len(values))