Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FreeBSD migration to .pkg extensions. #950

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Conversation

Alexhuszagh
Copy link
Contributor

Uses the path key rather than the version extension to get the proper location for the package URL, which is still compressed as a tar XZ archive.

@Alexhuszagh Alexhuszagh requested a review from a team as a code owner July 15, 2022 06:20
@Alexhuszagh

This comment was marked as outdated.

bors bot added a commit that referenced this pull request Jul 15, 2022
@Alexhuszagh

This comment was marked as outdated.

bors bot added a commit that referenced this pull request Jul 15, 2022
@bors

This comment was marked as outdated.

@Alexhuszagh
Copy link
Contributor Author

It might be worth adding a very rudimentary package install script here, since we effectively do this anyway, which would make it much simpler to install FreeBSD packages.

@Alexhuszagh
Copy link
Contributor Author

I've added /freebsd-install.sh as a simple package manager (trivial, but better than nothing) that installs packages to the target directory, simplifying builds that require other FreeBSD packages. We use this for OpenSSL and SQLite3.

@Alexhuszagh
Copy link
Contributor Author

bors try --target x86_64-unknown-freebsd

bors bot added a commit that referenced this pull request Jul 15, 2022
@bors
Copy link
Contributor

bors bot commented Jul 15, 2022

try

Build succeeded:

Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 15, 2022

Build succeeded:

@bors bors bot merged commit 8ff7c73 into cross-rs:main Jul 15, 2022
@Alexhuszagh Alexhuszagh deleted the bsd_extra branch July 15, 2022 23:30
@Emilgardis Emilgardis added this to the v0.3.0 milestone Aug 10, 2022
@Emilgardis Emilgardis modified the milestones: v0.3.0, v0.2.5 Feb 4, 2023
@Emilgardis Emilgardis mentioned this pull request Feb 4, 2023
bors bot added a commit that referenced this pull request Feb 4, 2023
1201: Release v0.2.5 r=Emilgardis a=Emilgardis

See #962 (comment)

includes

ee3c972 #962
fc3df66 #1166
33ee940 in #997
81c1e59 #950
6a57d01 #1183

Co-authored-by: Emil Gardström <[email protected]>
Co-authored-by: Alex Huszagh <[email protected]>
Co-authored-by: Taiki Endo <[email protected]>
bors bot added a commit that referenced this pull request Feb 4, 2023
1201: Release v0.2.5 r=Emilgardis a=Emilgardis

See #962 (comment)

includes

ee3c972 #962
fc3df66 #1166
33ee940 in #997
81c1e59 #950
6a57d01 #1183

Co-authored-by: Emil Gardström <[email protected]>
Co-authored-by: Alex Huszagh <[email protected]>
Co-authored-by: Taiki Endo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants