Fix linkage and C++ support for musl targets. #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try --target musl --cpp 1 |
|
This changes the default linkage, and will increase the executable size of the generated binaries (but only for C++ binaries, which currently don't really work anyway), but ensure maximum portability and allow libraries with C++ dependencies to build and run correctly. The following sizes exist:
|
Alexhuszagh
commented
Oct 7, 2022
tryBuild failed: |
|
The EDIT: Seems like the known bug: $ rustc --print native-static-libs src/lib.rs
note: Link against the following native artifacts when linking against this static library. The order and any duplication can be significant on some platforms.
note: native-static-libs: -lgcc_s -lutil -lrt -lpthread -lm -ldl -lc
$ rustc --print native-static-libs src/lib.rs --target mips-unknown-linux-musl
note: Link against the following native artifacts when linking against this static library. The order and any duplication can be significant on some platforms.
note: native-static-libs: -lgcc_s -lc
$ rustc --print native-static-libs src/lib.rs --target mips64-unknown-linux-muslabi64
note: Link against the following native artifacts when linking against this static library. The order and any duplication can be significant on some platforms.
note: native-static-libs: -lunwind -lc
$ rustc --print native-static-libs src/lib.rs --target aarch64-unknown-linux-musl
note: Link against the following native artifacts when linking against this static library. The order and any duplication can be significant on some platforms.
note: native-static-libs: -lunwind -lc |
|
bors try --target mips*musl --cpp 1 |
|
Changing this to a draft since it breaks if |
tryBuild succeeded: |
Change behavior to use static-pie linkage by default (consistent with Alpine's behavior for pure Rust packages as well as those with external C dependencies), and fix musl targets with C++ dependencies by forcing statie-pie linkage to standard libraries.
|
bors try --target mips*musl --cpp 1 Whoops this was supposed to be all musl targets. |
Alexhuszagh
commented
Oct 8, 2022
| @@ -182,6 +182,21 @@ main() { | |||
|
|
|||
| rm -rf "${td}" | |||
| fi | |||
|
|
|||
| # special tests for a shared C runtime, since we disable the shared c++ runtime | |||
There was a problem hiding this comment.
This doesn't need a check for C++ support since it's for a shared C runtime. The C++ runtime will always be static, and we've tested that above.
tryBuild succeeded: |
|
Build succeeded: |
This was referenced Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change behavior to use static-pie linkage by default (consistent with Alpine's behavior for pure Rust packages as well as those with external C dependencies), and fix musl targets with C++ dependencies by forcing static-pie linkage to standard libraries.
Closes #902.