Skip to content

Commit

Permalink
don't look at package.metadata.cross when the package isn't part of…
Browse files Browse the repository at this point in the history
… the current workspace (#1623)

resolves #1619
  • Loading branch information
Emilgardis authored Feb 6, 2025
2 parents 4090bec + a9b43d4 commit 107433f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
4 changes: 4 additions & 0 deletions .changes/1623.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "fixed",
"description": "fixed an issue where cross would look for metadata.cross outside the workspace"
}
5 changes: 3 additions & 2 deletions deny.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@ targets = [

[advisories]
version = 2
# FIXME: remove this if/when clap changes to is-terminal, atty is
# patched, or we migrated to an MSRV of 1.66.0.
ignore = [
# FIXME: remove this if/when clap changes to is-terminal, atty is
# patched, or we migrated to an MSRV of 1.66.0.
"RUSTSEC-2021-0145",
"RUSTSEC-2024-0375"
]

[bans]
Expand Down
1 change: 1 addition & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -959,6 +959,7 @@ pub fn toml(metadata: &CargoMetadata, msg_info: &mut MessageInfo) -> Result<Cros
for (package, package_metadata) in metadata
.packages
.iter()
.filter(|p| metadata.workspace_members.contains(&p.id))
.filter_map(|p| Some((p.manifest_path.as_path(), p.metadata.as_deref()?)))
{
let package_metadata =
Expand Down

0 comments on commit 107433f

Please sign in to comment.